Skip to content

Upgrade gogit and cryto #33142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Upgrade gogit and cryto #33142

wants to merge 2 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 7, 2025 •
edited
Loading

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jan 7, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 7, 2025
@lunny lunny added the backport/v1.23 This PR should be backported to Gitea 1.23 label Jan 7, 2025
@lunny lunny requested a review from techknowlogick January 7, 2025 21:55
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 7, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 7, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) January 8, 2025 00:00
@techknowlogick
Copy link
Member

CI fail might be related

@lunny lunny disabled auto-merge January 8, 2025 00:55
@lunny
Copy link
Member Author

lunny commented Jan 8, 2025

It's wired that I can't reproduce it in a local env. with make test-sqlite#TestExternalMarkupRenderer

@lunny
Copy link
Member Author

lunny commented Jan 8, 2025

Looks like the changes have been merged into #33097

@lunny lunny closed this Jan 8, 2025
@lunny lunny deleted the lunny/upgrade_gogit branch January 8, 2025 02:33
@lunny lunny removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. backport/v1.23 This PR should be backported to Gitea 1.23 labels Mar 3, 2025
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
modifies/dependencies topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @techknowlogick @lafriks @GiteaBot