Fix Account linking page #33325
Merged
Fix Account linking page #33325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 19, 2025 17:28
GiteaBot
added
the
lgtm/need 2
|
We run a Gitea in our infrastructure. Since upgrade to 1.23, we found the account linking page broken. We verified backend configuration and found nowhere wrong. No custom template modification made either. I believe it's a bug as everything in account linking was fine in 1.22. |
github-actions
bot
added
modifies/go
|
Before:
After:
|
wxiaoguang
approved these changes
Jan 19, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
added
backport/v1.23
|
This PR is from an org, so maintainers can't edit it. I think there are still some UI problems .... maybe they could be fixed later. Or would you like to create a PR from your personal account? Or maybe I can create a PR based on yours? |
|
Hi @wxiaoguang ! It should be editable by now. Could you elaborate further on UI issue? |
I will make some more fixes and try to add a test for the "link account" page. |
|
Fixed UI:
|
|
And added some tests in dd3a94c, to make sure it won't break again. To make backport easier, many legacy code are kept as-is. |
hiifong
approved these changes
Jan 19, 2025
GiteaBot
removed
the
lgtm/need 1
GiteaBot
added
the
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jan 19, 2025
Fix password form missing whilst linking account even with `ENABLE_PASSWORD_SIGNIN_FORM = true`. Remove redundant empty box in account linking sign up page when `LinkAccountMode` is true. --------- Co-authored-by: wxiaoguang <[email protected]>
wxiaoguang
added a commit
that referenced
this pull request
Jan 19, 2025
Backport #33325 by CrimsonEdgeHope Fix password form missing whilst linking account even with `ENABLE_PASSWORD_SIGNIN_FORM = true`. Remove redundant empty box in account linking sign up page when `LinkAccountMode` is true. Co-authored-by: CrimsonEdgeHope <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 20, 2025
* giteaofficial/main: [skip ci] Updated licenses and gitignores Fix typo in documentation of GetBranchNames() (go-gitea#33330) Fix Account linking page (go-gitea#33325) Fix parentCommit invalid memory address or nil pointer dereference. (go-gitea#33204) Make tracked time representation display as hours (go-gitea#33315) [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin Fix push message behavior (go-gitea#33215) Add golang back to nix dev environment and pin v1.23 (go-gitea#33275) Trivial fixes (go-gitea#33304)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix password form missing whilst linking account even with
ENABLE_PASSWORD_SIGNIN_FORM = true.Remove redundant empty box in account linking sign up page when
LinkAccountModeis true.