Skip to content

Do not show unnecessary commit sign lock icon #33387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2025
Merged

Do not show unnecessary commit sign lock icon #33387

merged 1 commit into from
Jan 25, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix #33385

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 25, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Jan 25, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jan 25, 2025 •
edited
Loading

image

image

@wxiaoguang wxiaoguang mentioned this pull request Jan 25, 2025
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 25, 2025
@wxiaoguang wxiaoguang added the backport/v1.23 This PR should be backported to Gitea 1.23 label Jan 25, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 25, 2025
@wxiaoguang wxiaoguang merged commit 6a516a0 into go-gitea:main Jan 25, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 25, 2025
@wxiaoguang wxiaoguang deleted the fix-commit-sign branch January 25, 2025 12:24
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.23. @wxiaoguang, please send one manually. 🍵

go run ./contrib/backport 33387
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Jan 25, 2025
@wxiaoguang wxiaoguang removed backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 labels Jan 25, 2025
@wxiaoguang
Copy link
Contributor Author

Not in 1.23

@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 25, 2025
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Lots of unnecessary/repetitive unlocked icons in commit list
4 participants
@wxiaoguang @GiteaBot @lunny @hiifong