Skip to content

Fix possible bug when migrating issues/pull requests#33487

Merged
lunny merged 10 commits into
go-gitea:mainfrom
lunny:lunny/fix_migrate_issue_bug
Dec 8, 2025
Merged

Fix possible bug when migrating issues/pull requests#33487
lunny merged 10 commits into
go-gitea:mainfrom
lunny:lunny/fix_migrate_issue_bug

Conversation

@lunny
Copy link
Copy Markdown
Member

@lunny lunny commented Feb 3, 2025

When migrating issues or pull requests from a big repository, some issue/pull request maybe deleted when migrating. So that there will be duplicated issues/pull requests because we are get information with pagination. This PR introduced a map to record all migrated issue pull request index when migrating to avoid the failure because of duplicated records.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 3, 2025
@lunny lunny mentioned this pull request Feb 4, 2025
@lunny lunny marked this pull request as draft February 11, 2025 07:08
@lunny lunny added this to the 1.26.0 milestone Sep 30, 2025
@lunny lunny added the backport/v1.25 This PR should be backported to Gitea 1.25 label Sep 30, 2025
@lunny lunny marked this pull request as ready for review September 30, 2025 00:17
Comment thread services/migrations/migrate.go Outdated
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 20, 2025
@lunny lunny removed the backport/v1.25 This PR should be backported to Gitea 1.25 label Oct 22, 2025
@lunny
Copy link
Copy Markdown
Member Author

lunny commented Nov 26, 2025

last call @go-gitea/technical-oversight-committee

@lunny lunny enabled auto-merge (squash) December 8, 2025 07:05
@lunny lunny disabled auto-merge December 8, 2025 07:09
@lunny lunny merged commit 69700f9 into go-gitea:main Dec 8, 2025
22 of 23 checks passed
@lunny lunny deleted the lunny/fix_migrate_issue_bug branch December 8, 2025 07:09
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 9, 2025
* giteaofficial/main:
  Fix possible bug when migrating issues/pull requests (go-gitea#33487)
  allow action user have read permission in public repo like other user (go-gitea#36095)
  [skip ci] Updated translations via Crowdin
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants