Fix project issues list and counting#33594
Merged
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
lunny
force-pushed
the
lunny/fix_project_issues_list
branch
from
1bc5c2c to
5878ceb
Compare
wxiaoguang
reviewed
Feb 16, 2025
wxiaoguang
reviewed
Feb 16, 2025
wxiaoguang
reviewed
Feb 16, 2025
delvh
approved these changes
Feb 16, 2025
|
|
||
| // MustDefaultColumn returns the default column for a project, get the first one if exist one and creating one if it does not exist | ||
| func (p *Project) MustDefaultColumn(ctx context.Context) (*Column, error) { | ||
| c, err := p.getDefaultColumn(ctx) |
Member
There was a problem hiding this comment.
The Desc(id) in the called method seems incorrect.
Shouldn't it be Asc(sorting, id) instead?
(even if it might be potentially minimally breaking if someone misconfigured their projects)
Member
Author
There was a problem hiding this comment.
I think it's already OrderBy("sorting, id")?
Contributor
There was a problem hiding this comment.
I do not think it should change the existing logic in getDefaultColumn
The old logic means this: use the latest default one. It doesn't care about "sorting" or not. There should be only one "default" column, the "order by" is just a fallback.
wxiaoguang
reviewed
Feb 17, 2025
wxiaoguang
previously approved these changes
Feb 17, 2025
GiteaBot
added
lgtm/done
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Feb 17, 2025
wxiaoguang
reviewed
Feb 17, 2025
wxiaoguang
approved these changes
Feb 17, 2025
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Feb 17, 2025
Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
wxiaoguang
added a commit
that referenced
this pull request
Feb 17, 2025
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 18, 2025
* giteaofficial/main: Make actions URL in commit status webhooks absolute (go-gitea#33620) Refactor error system (go-gitea#33626) Move issue pin to an standalone table for querying performance (go-gitea#33452) Run spellcheck on tools directory (go-gitea#33627) Refactor error system (go-gitea#33610) Fix project issues list and counting (go-gitea#33594)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.