Skip to content

Refactor markup and pdf-viewer to use new init framework #33772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 3, 2025
Merged

Refactor markup and pdf-viewer to use new init framework #33772

merged 4 commits into from
Mar 3, 2025

Conversation

kerwin612
Copy link
Member

@kerwin612 kerwin612 commented Mar 3, 2025 •
edited by wxiaoguang
Loading

  1. Add some "render-content" classes to "markup" elements when the content is rendered
  2. Use correct "markup" wrapper for "preview" (but not set that class on the tab)
  3. Remove incorrect "markup" class from LFS file view, because there is no markup content
    • "edit-diff" is also removed because it does nothing
  4. Use "initPdfViewer" for PDF viewer
  5. Remove incorrect "content" class from milestone markup
  6. Init all ".markup" elements by new init framework

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 3, 2025
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Mar 3, 2025
@pull-request-size pull-request-size bot added size/L and removed size/S labels Mar 3, 2025
@wxiaoguang wxiaoguang changed the title Refactor initPdfViewer Using the New registerGlobalInitFunc Refactor markup and pdf-viewer to use new init framework Mar 3, 2025
@wxiaoguang wxiaoguang mentioned this pull request Mar 3, 2025
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 3, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 3, 2025
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 3, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 3, 2025
@lunny lunny merged commit f0f1737 into go-gitea:main Mar 3, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 3, 2025
@kerwin612 kerwin612 deleted the refactor-initpdfviewer-with-registerglobalinitfunc branch March 4, 2025 00:06
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 4, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7657e9d 
* giteaofficial/main:
  Adjust appearence of commit status webhook (go-gitea#33778)
  Refactor initRepoBranchTagSelector to use new init framework (go-gitea#33776)
  Refactor buttons to use new init framework (go-gitea#33774)
  Refactor markup and pdf-viewer to use new init framework (go-gitea#33772)
wxiaoguang
wxiaoguang reviewed Apr 4, 2025
View reviewed changes
web_src/js/markup/math.ts
if (!els.length) return;
export async function initMarkupCodeMath(elMarkup: HTMLElement): Promise<void> {
const el = elMarkup.querySelector('code.language-math'); // .markup code.language-math'
if (!el) return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression, here and other similar places: it only initializes the first element, others are not initialized.

The fix is done in Fix markdown render behaviors #34122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kerwin612 @lunny @wxiaoguang @GiteaBot