Skip to content

Only keep popular licenses #33832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2025
Merged

Only keep popular licenses #33832

merged 2 commits into from
Mar 9, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 9, 2025 •
edited
Loading

Fix #33467

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 9, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/internal labels Mar 9, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Mar 9, 2025 •
edited
Loading

GitHub has 13 licenses: https://github.com/new

Now we keep 28. Thanks to eeyrjmr's analysis!

0BSD          BSD-3-Clause-Clear  EPL-1.0   ISC       MPL-2.0       Unlicense
AGPL-3.0      BSL-1.0             EPL-2.0   LGPL-2.1  MulanPSL-2.0  WTFPL
Apache-2.0    CC-BY-4.0           EUPL-1.2  LGPL-3.0  OFL-1.1       Zlib
BSD-2-Clause  CC-BY-SA-4.0        GPL-2.0   MIT       OSL-3.0
BSD-3-Clause  CC0-1.0             GPL-3.0   MIT-0     UPL-1.0

@wxiaoguang wxiaoguang mentioned this pull request Mar 9, 2025
Closed
@wxiaoguang wxiaoguang force-pushed the fix-licneses branch 2 times, most recently from 9856c8f to 8a9f9d8 Compare March 9, 2025 12:26
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 9, 2025
techknowlogick
techknowlogick approved these changes Mar 9, 2025
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will improve the experience. I recently tried to have MIT as a license and had to scroll down a lot in the dropdown even after searching for the exact string.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 9, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 9, 2025
@wxiaoguang wxiaoguang merged commit 7290bfa into go-gitea:main Mar 9, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-licneses branch March 9, 2025 22:40
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 10, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7aa16d2 
* giteaofficial/main:
  Move notifywatch to service layer (go-gitea#33825)
  [skip ci] Updated translations via Crowdin
  Only keep popular licenses (go-gitea#33832)
  Removing unwanted ui container (go-gitea#33833)
  Full-file syntax highlighting for diff pages (go-gitea#33766)
  Improve theme display (go-gitea#30671)
  Decouple context from repository related structs (go-gitea#33823)
  Improve log format (go-gitea#33814)
  Decouple diff stats query from actual diffing (go-gitea#33810)
  Add global lock for migrations to make upgrade more safe with multiple replications (go-gitea#33706)
  Do not show passkey on http sites (go-gitea#33820)
This was referenced Mar 10, 2025
Closed
Closed
hiifong pushed a commit to hiifong/gitea that referenced this pull request Mar 10, 2025
@wxiaoguang @hiifong
Only keep popular licenses (go-gitea#33832)
8e07976 
Fix go-gitea#33467

(cherry picked from commit 7290bfa)
@wxiaoguang wxiaoguang mentioned this pull request Apr 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/internal
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Proposal: remove unpopular licenses
4 participants
@wxiaoguang @lunny @techknowlogick @GiteaBot