Skip to content

Add fullscreen mode as a more efficient operation way to view projects #34081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add fullscreen mode as a more efficient operation way to view projects #34081

wants to merge 11 commits into from
+89 −31

Conversation

kerwin612
Copy link
Member

@kerwin612 kerwin612 commented Mar 31, 2025 •
edited
Loading

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 31, 2025
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Mar 31, 2025
@kerwin612 kerwin612 marked this pull request as draft March 31, 2025 03:20
@kerwin612 kerwin612 mentioned this pull request Mar 31, 2025
Open
@kerwin612
Copy link
Member Author

kerwin612 commented Apr 14, 2025 •
edited
Loading

fullscreen

@kerwin612 kerwin612 marked this pull request as ready for review April 14, 2025 03:11
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 14, 2025
@wxiaoguang
Copy link
Contributor

Could the "Actions Logs" fullscreen share the same logic?

@delvh delvh changed the title [Feat] Add full - screen mode as a more efficient operation way to view projects Add fullscreen mode as a more efficient operation way to view projects Apr 14, 2025
@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI type/feature Completely new functionality. Can only be merged if feature freeze is not active. and removed type/enhancement An improvement of existing functionality labels Apr 14, 2025
@kerwin612 kerwin612 requested a review from wxiaoguang April 16, 2025 02:39
wxiaoguang
wxiaoguang reviewed Apr 18, 2025
View reviewed changes
templates/org/projects/view.tmpl Outdated
<div class="ui container fluid padded">
{{template "projects/view" .}}
<div class="ui container fluid padded org-projects-view">
{{template "projects/view" dict "." . "FullscreenElementsSelector" ".org-projects-view"}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old layout is not right, the new change makes things worse.

projects/view already has its own "ui container" and it could have a unified CSS class name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very sorry. From what I can see on the page, I don't find anything inappropriate. I can't tell what's wrong with the layout. Or rather, I don't understand what you think the correct layout should be.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See latest commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/frontend modifies/templates This PR modifies the template files modifies/translation topic/ui Change the appearance of the Gitea UI type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kerwin612 @wxiaoguang @hiifong @techknowlogick @GiteaBot