Skip to content

[WIP] Updates of the builder backend#341

Closed
denji wants to merge 1 commit into
go-gitea:masterfrom
denji:web
Closed

[WIP] Updates of the builder backend#341
denji wants to merge 1 commit into
go-gitea:masterfrom
denji:web

Conversation

@denji
Copy link
Copy Markdown
Contributor

@denji denji commented Dec 2, 2016

Updates of the builder backend

sic

Cleanup unchanged, moved all external dependencies on the modules:

  • package.json
  • ./public/js/[module].{css,js,es6,jsx}

./assets/ folder left some folders which were changed by deploy stage.

Code style

Build

  • Webpack 2.2
    • webpack.config.js

@tboerger
Copy link
Copy Markdown
Member

tboerger commented Dec 2, 2016

This needs to be tested if it breaks anything.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 2, 2016
@denji
Copy link
Copy Markdown
Contributor Author

denji commented Dec 2, 2016

In the future is to make bootstraping gulp/webpack2/rollup without the use of storing unnecessary unpackaged files.

@tboerger
Copy link
Copy Markdown
Member

tboerger commented Dec 2, 2016

Yeah I would like to add webpack or something like that as well, but the asset bundle will always be part of the repo because we don't want to blow up the build requirements.

Comment thread .gitignore Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these changes, there is so much junk inside that shouldn't be part of a project gitignore. Build your own global gitignore that ignores things like that.

@tboerger
Copy link
Copy Markdown
Member

tboerger commented Dec 2, 2016

And the diff is grown so much that it's not really reviewable anymore -.-

@tboerger
Copy link
Copy Markdown
Member

tboerger commented Dec 2, 2016

And one more nitpicking, please write meaningful commit messages :)

@tboerger
Copy link
Copy Markdown
Member

tboerger commented Dec 2, 2016

After thinking about it, we should delay that to 1.1 because there is so much breaking potential

@denji denji changed the title Refresh javascript libraries [WIP] Updates of the builder backend Dec 2, 2016
@tboerger tboerger added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Dec 2, 2016
@tboerger tboerger added this to the 1.1.0 milestone Dec 2, 2016
@bkcsoft
Copy link
Copy Markdown
Contributor

bkcsoft commented Dec 3, 2016

You can't just "Update" PDF.js, since I had to remove a lot of stuff from it so as to not bloat the feature...

@bkcsoft bkcsoft added the pr/wip This PR is not ready for review label Dec 3, 2016
@bkcsoft
Copy link
Copy Markdown
Contributor

bkcsoft commented Dec 6, 2016

@denji Do you actually have a reason to update all these dependencies?

You can't really expect anyone to review 1600 files... even if it's just deps...

@lunny lunny modified the milestones: 1.2.0, 1.1.0 Feb 5, 2017
@lunny lunny removed this from the 1.2.0 milestone Apr 20, 2017
@lunny
Copy link
Copy Markdown
Member

lunny commented Apr 20, 2017

I think this PR is so big that almost nobody could review that. So I close this one.

@lunny lunny closed this Apr 20, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. pr/wip This PR is not ready for review topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants