Skip to content

Fix markdown frontmatter rendering #34102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix #34101

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 2, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/frontend labels Apr 2, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Apr 2, 2025

Old UI

image

image

New UI

image

image

@wxiaoguang wxiaoguang force-pushed the fix-markdown-frontmatter branch 2 times, most recently from c5df0ce to 28b6314 Compare April 2, 2025 14:01
@wxiaoguang wxiaoguang force-pushed the fix-markdown-frontmatter branch from 28b6314 to 31af204 Compare April 2, 2025 14:02
@wxiaoguang wxiaoguang added backport/v1.23 This PR should be backported to Gitea 1.23 type/bug labels Apr 2, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 2, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 3, 2025
@lunny lunny enabled auto-merge (squash) April 3, 2025 05:23
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 3, 2025
@lunny lunny merged commit ba921fd into go-gitea:main Apr 3, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Apr 3, 2025
@GiteaBot
Copy link
Collaborator

GiteaBot commented Apr 3, 2025

I was unable to create a backport for 1.23. @wxiaoguang, please send one manually. 🍵

go run ./contrib/backport 34102
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 3, 2025
@wxiaoguang wxiaoguang deleted the fix-markdown-frontmatter branch April 3, 2025 06:02
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Apr 3, 2025
Fix go-gitea#34101
# Conflicts:
#	modules/markup/markdown/renderconfig_test.go
@wxiaoguang
Copy link
Contributor Author

Backport: Fix markdown frontmatter rendering #34107

@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Apr 3, 2025
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Apr 3, 2025
Fix go-gitea#34101
# Conflicts:
#	modules/markup/markdown/renderconfig_test.go
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Apr 3, 2025
Fix go-gitea#34101
# Conflicts:
#	modules/markup/markdown/renderconfig_test.go
wxiaoguang added a commit that referenced this pull request Apr 3, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 8, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  docs: add Chinese translations for README files (go-gitea#34132)
  Keep file tree view icons consistent with icon theme (go-gitea#33921)
  Make markdown render match GitHub's behavior (go-gitea#34129)
  Remove dead code: RepoRef (go-gitea#34131)
  Correctly handle submodule view and avoid throwing 500 error (go-gitea#34121)
  Use `overflow-wrap: anywhere` to replace `word-break: break-all` (go-gitea#34126)
  Fix markdown render behaviors (go-gitea#34122)
  Refactor dropdown ellipsis (go-gitea#34123)
  Avoid creating unnecessary temporary cat file sub process (go-gitea#33942)
  Fix discord webhook 400 status code when description limit is exceeded (go-gitea#34084)
  Refactor markup render to fix various path problems (go-gitea#34114)
  [skip ci] Updated translations via Crowdin
  Fix invalid version in RPM package path (go-gitea#34112)
  also check default ssh-cert location for host (go-gitea#34099) (go-gitea#34100)
  Fix markdown frontmatter rendering (go-gitea#34102)
  Get changed files based on merge base when checking `pull_request` actions trigger (go-gitea#34106)
  Add `last_committer_date` and `last_author_date` for file contents API (go-gitea#32921)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontmatter summary icon is not displayed
4 participants