Skip to content

Fix possible notify watch failure because the content is too long than database can store. #34233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2025
Merged

Fix possible notify watch failure because the content is too long than database can store. #34233

merged 3 commits into from
Apr 20, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 17, 2025

Fix #28193

@lunny lunny added type/bug backport/v1.23 This PR should be backported to Gitea 1.23 labels Apr 17, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 17, 2025
@lunny lunny added this to the 1.24.0 milestone Apr 17, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 17, 2025
wxiaoguang
wxiaoguang reviewed Apr 18, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Apr 18, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 18, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) April 20, 2025 02:25
@wxiaoguang wxiaoguang merged commit 6d3c674 into go-gitea:main Apr 20, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the lunny/trunk_action_content branch April 20, 2025 02:50
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.23. @lunny, please send one manually. 🍵

go run ./contrib/backport 34233
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 20, 2025
@lunny lunny removed the backport/v1.23 This PR should be backported to Gitea 1.23 label Apr 20, 2025
@lunny
Copy link
Member Author

lunny commented Apr 20, 2025

I will not backport this as it needs to introduce many utils functions.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 21, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b623b85 
* giteaofficial/main:
  Add API routes to lock and unlock issues (go-gitea#34165)
  Make ROOT_URL support using request Host header (go-gitea#32564)
  Valid email address should only start with alphanumeric (go-gitea#28174)
  Fix notify watch failure when the content is too long (go-gitea#34233)
  Add "--fullname" arg to gitea admin user create (go-gitea#34241)
  Fix various UI problems (go-gitea#34243)
  markup: improve code block readability and isolate copy button (go-gitea#34009)
  Don't assume the default wiki branch is master in the wiki API (go-gitea#34244)
  [skip ci] Updated translations via Crowdin
  Optimize the calling code of queryElems (go-gitea#34235)
  Actions Runner rest api (go-gitea#33873)
  Fix some trivial problems (go-gitea#34237)
  Swift files can be passed either as file or as form value (go-gitea#34068)

# Conflicts:
#	templates/repo/wiki/revision.tmpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug
Projects
None yet
Milestone
1.24.0
4 participants
@lunny @GiteaBot @wxiaoguang @hiifong