Fix removing some packages will result dirty data

[lunny]

Fix #32830

Inspired by #22810 and replace it.

When deleting alphe, cargo, debian, rpm packages, some extra actions should be taken which was missed. It will result in dirty data and inconsistent. This PR fix it. To avoid recycle dependencies, this is a quick patch. Like #22810 (comment) said, this might need a new design for such more packages types.

[KN4CK3R]

I don't think this is cleaner than my PR. With this change some package types must call the remove method from the router, other types must call the remove method from the service.

[lunny]

I don't think this is cleaner than my PR. With this change some package types must call the remove method from the router, other types must call the remove method from the service.

Your implementation will still have a chance to fail with dirty data. The alpine_service.BuildAllRepositoryFiles(ctx, pd.Owner.ID) should be invoked in the same transaction inside RemovePackageVersion and the notification should not be invoked before all cleanup succeed. Currently, only routers invoke these functions, a new service package could be introduced if it will be invoked from command or other packages. As a quick patch, I think it's enough.

[wxiaoguang]

Why the common is in "routers" package but not "services"?

[wxiaoguang]

If you need to resolve the dependency problem, it should be something like services/packagemanager to manage all packages.

[wxiaoguang]

It calls RemovePackageVersion mutiple times and "build" again and again. It doesn't seem right.

It should introduce a final step to rebuild when the removal finishes.

[wxiaoguang]

Don't backport since the design still has problems and no test.

[ExplodingDragon]

Simply removing packages by version may cause issues, as identical versions can contain files residing in different groups (refer to #26984), governed by PackageFile.CompositeKey (

gitea/models/packages/package_file.go

Line 40 in 04017f2

CompositeKey string `xorm:"UNIQUE(s) INDEX"`

).

For instance, package example might be non-latest in Alice’s group while being the latest in Bob’s group. If configured with a "retain-only-latest-versions" policy, cleanup should exclusively target example in Alice’s group.

A real-world case: gitea 1.23.8 in alpine/3.22 and 1.22.4 in alpine/3.21—both are the latest versions within their respective groups. Consequently, older versions should not be indiscriminately purged.

BTW cleanup functionality is actually implemented twice in the codebase:

services/packages/cleanup/cleanup.go#executeCleanupOneRulePackage
routers/web/shared/packages/packages.go#SetRulePreviewContext

This duplication may cause discrepancies between the preview results and actual execution outcomes.

[wxiaoguang]

Now there is a clear framework ( just like I said: https://github.com/go-gitea/gitea/pull/34709/files#r2159857228 )

See Add terraform state registry #36710 2bbc654