Skip to content

Reload issue when sending webhook to make num comments is right. #35243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 11, 2025
Merged

Reload issue when sending webhook to make num comments is right. #35243

merged 6 commits into from
Aug 11, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 9, 2025

Fix #35229

@lunny lunny added type/bug backport/v1.24 This PR should be backported to Gitea 1.24 labels Aug 9, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 9, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Aug 9, 2025
kemzeb
kemzeb reviewed Aug 9, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 9, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 10, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 10, 2025
@silverwind silverwind enabled auto-merge (squash) August 11, 2025 11:03
@silverwind silverwind merged commit 87b28b3 into go-gitea:main Aug 11, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Aug 11, 2025
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request Aug 11, 2025
@lunny @GiteaBot
Reload issue when sending webhook to make num comments is right. (go-…
80d7159 
…gitea#35243)

Fix go-gitea#35229

---------

Co-authored-by: Giteabot <[email protected]>
@GiteaBot GiteaBot mentioned this pull request Aug 11, 2025
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Aug 11, 2025
lunny added a commit that referenced this pull request Aug 11, 2025
@GiteaBot @lunny
Reload issue when sending webhook to make num comments is right. (#35243
4e0269e 
) (#35248)

Backport #35243 by @lunny

Fix #35229

Co-authored-by: Lunny Xiao <[email protected]>
@lunny lunny deleted the lunny/fix_inconsistent_numcomment_webhook branch August 11, 2025 17:15
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 12, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
0f8c04d 
* giteaofficial/main:
  modules/setting/actions.go: fixed typo: ì->i (go-gitea#35253)
  Reload issue when sending webhook to make num comments is right. (go-gitea#35243)
  Update chroma to v2.20.0 (go-gitea#35220)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@kemzeb kemzeb kemzeb approved these changes

@hiifong hiifong hiifong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

Webhook value comments contains wrong comment count
5 participants
@lunny @kemzeb @hiifong @silverwind @GiteaBot