Address some CodeQL security concerns#35572
Merged
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
silverwind
reviewed
Oct 3, 2025
silverwind
reviewed
Oct 3, 2025
silverwind
approved these changes
Oct 3, 2025
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Oct 3, 2025
lunny
approved these changes
Oct 3, 2025
GiteaBot
added
lgtm/done
wxiaoguang
added
the
skip-changelog
wxiaoguang
commented
Oct 3, 2025
| if err != nil { | ||
| return err | ||
| } | ||
| // codeql[disable-next-line=go/clear-text-logging] |
Contributor
Author
There was a problem hiding this comment.
It's a shame that CodeQL doesn't support such inline-disabling. I was cheated by AI.
CodeQL is missing an inline mechanism to suppress warnings github/codeql#11427
Member
There was a problem hiding this comment.
Never blindly trust AI, always verify 😆
Contributor
Author
There was a problem hiding this comment.
Yup, I never blindly trust AI. But at the moment I don't have a way to test the CodeQL related changes locally. So after the merge, I checked the result immediately .....
If anyone knows to how to test CodeQL locally, please suggest. 🙏
Member
There was a problem hiding this comment.
It seems there is a codeql cli, but it requires some setup and a "database" being generated:
https://medium.com/@arjun_zs/codeql-cli-running-in-local-the-how-5817175300c6
Maybe we can add a make codeql that does it all.
rossigee
pushed a commit
to rossigee/gitea
that referenced
this pull request
Oct 4, 2025
Although there is no real security problem
rossigee
pushed a commit
to rossigee/gitea
that referenced
this pull request
Oct 4, 2025
Although there is no real security problem
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 5, 2025
* giteaofficial/main: fix: auto-expand and auto-scroll for actions logs (go-gitea#35570) (go-gitea#35583) [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin Fix creating pull request failure when the target branch name is the same as some tag (go-gitea#35552) Use bundled version of spectral (go-gitea#35573) Add rebase push display wrong comments bug (go-gitea#35560) Address some CodeQL security concerns (go-gitea#35572) fix(webhook): prevent tag events from bypassing branch filters targets go-gitea#35449 (go-gitea#35567) Added button to copy file name in PR files (go-gitea#35509) Update JS and PY deps (go-gitea#35565) Enable a few more tsconfig options (go-gitea#35553) Bump github.com/wneessen/go-mail from 0.6.2 to 0.7.1 (go-gitea#35557) add more routes to the "expensive" list (go-gitea#35547) Drop json-iterator dependency (go-gitea#35544) Add proper error message if session provider can not be created (go-gitea#35520) use experimental go json v2 library (go-gitea#35392) Use global lock instead of status pool for cron lock (go-gitea#35507) Move some functions to gitrepo package (go-gitea#35503) Move GetDiverging functions to gitrepo (go-gitea#35524) [skip ci] Updated translations via Crowdin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although there is no real security problem