Skip to content

Fix cli "Before" handling#35797

Merged
lunny merged 5 commits into
go-gitea:mainfrom
wxiaoguang:fix-cli-before
Oct 31, 2025
Merged

Fix cli "Before" handling#35797
lunny merged 5 commits into
go-gitea:mainfrom
wxiaoguang:fix-cli-before

Conversation

@wxiaoguang
Copy link
Copy Markdown
Contributor

@wxiaoguang wxiaoguang commented Oct 30, 2025

Regression of #34973

Fix #35796

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 30, 2025
@wxiaoguang wxiaoguang requested a review from TheFox0x7 October 30, 2025 23:13
@wxiaoguang wxiaoguang added type/bug issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change backport/v1.25 This PR should be backported to Gitea 1.25 labels Oct 30, 2025
Copy link
Copy Markdown
Contributor

@TheFox0x7 TheFox0x7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order was incorrect I take it?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 30, 2025
@wxiaoguang
Copy link
Copy Markdown
Contributor Author

The order was incorrect I take it?

It seems so, I added more tests and comments

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 31, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 31, 2025
@lunny lunny enabled auto-merge (squash) October 31, 2025 17:42
@lunny lunny merged commit de70cd3 into go-gitea:main Oct 31, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Oct 31, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 31, 2025
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 31, 2025
silverwind pushed a commit that referenced this pull request Oct 31, 2025
Backport #35797 by @wxiaoguang

Regression of #34973

Fix #35796

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang wxiaoguang deleted the fix-cli-before branch November 1, 2025 02:50
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 3, 2025
* giteaofficial/main:
  Add cache to container build (go-gitea#35697)
  Revert gomail to v0.7.0 to fix sending mail failed (go-gitea#35816)
  Fix circular spin animation direction (go-gitea#35785)
  Fix clone mixed bug (go-gitea#35810)
  [skip ci] Updated translations via Crowdin
  Remove unnecessary function parameter (go-gitea#35765)
  Fix cli "Before" handling (go-gitea#35797)
  Add test for ExtendCommentTreePathLength migration and fix bugs (go-gitea#35791)
  Fix file extension on gogs.png (go-gitea#35793)
  Improve and fix markup code preview rendering (go-gitea#35777)
project-mirrors-bot-tu Bot pushed a commit to project-mirrors/gitea-helm-chart that referenced this pull request Nov 5, 2025
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [go-gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.25.0` -> `1.25.1` |

---

### Release Notes

<details>
<summary>go-gitea/gitea (go-gitea/gitea)</summary>

### [`v1.25.1`](https://github.com/go-gitea/gitea/releases/tag/v1.25.1)

[Compare Source](go-gitea/gitea@v1.25.0...v1.25.1)

- BUGFIXES
  - Make ACME email optional ([#&#8203;35849](go-gitea/gitea#35849)) [#&#8203;35857](go-gitea/gitea#35857)
  - Add a doctor command to fix inconsistent run status ([#&#8203;35840](go-gitea/gitea#35840)) ([#&#8203;35845](go-gitea/gitea#35845))
  - Remove wrong code ([#&#8203;35846](go-gitea/gitea#35846))
  - Fix viewed files number is not right if not all files loaded ([#&#8203;35821](go-gitea/gitea#35821)) ([#&#8203;35844](go-gitea/gitea#35844))
  - Fix incorrect pull request counter ([#&#8203;35819](go-gitea/gitea#35819)) ([#&#8203;35841](go-gitea/gitea#35841))
  - Upgrade go mail to 0.7.2 and fix the bug ([#&#8203;35833](go-gitea/gitea#35833)) ([#&#8203;35837](go-gitea/gitea#35837))
  - Revert gomail to v0.7.0 to fix sending mail failed ([#&#8203;35816](go-gitea/gitea#35816)) ([#&#8203;35824](go-gitea/gitea#35824))
  - Fix clone mixed bug ([#&#8203;35810](go-gitea/gitea#35810)) ([#&#8203;35822](go-gitea/gitea#35822))
  - Fix cli "Before" handling ([#&#8203;35797](go-gitea/gitea#35797)) ([#&#8203;35808](go-gitea/gitea#35808))
  - Improve and fix markup code preview rendering ([#&#8203;35777](go-gitea/gitea#35777)) ([#&#8203;35787](go-gitea/gitea#35787))
  - Fix actions rerun bug ([#&#8203;35783](go-gitea/gitea#35783)) ([#&#8203;35784](go-gitea/gitea#35784))
  - Fix actions schedule update issue ([#&#8203;35767](go-gitea/gitea#35767)) ([#&#8203;35774](go-gitea/gitea#35774))
  - Fix circular spin animation direction ([#&#8203;35785](go-gitea/gitea#35785)) ([#&#8203;35823](go-gitea/gitea#35823))
  - Fix file extension on gogs.png ([#&#8203;35793](go-gitea/gitea#35793)) ([#&#8203;35799](go-gitea/gitea#35799))
  - Add pnpm to Snapcraft ([#&#8203;35778](go-gitea/gitea#35778))

Instances on **[Gitea Cloud](https://cloud.gitea.com)** will be automatically upgraded to this version during the specified maintenance window.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xOC4xIiwidXBkYXRlZEluVmVyIjoiNDEuMTguMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsia2luZC9kZXBlbmRlbmN5Il19-->

Reviewed-on: https://gitea.com/gitea/helm-gitea/pulls/981
Reviewed-by: Markus Pesch <volker.raschek@noreply.gitea.com>
Co-authored-by: Renovate Bot <renovate-bot@gitea.com>
Co-committed-by: Renovate Bot <renovate-bot@gitea.com>
@xnox xnox mentioned this pull request Dec 7, 2025
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created backport/v1.25 This PR should be backported to Gitea 1.25 issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Git pull/push is hanging in 1.25.0 (fixed in 1.25 nightly and will be released as 1.25.1)

4 participants