Use GitHub-style commit message for squash merge#35987
Conversation
| expectedMessage: `* Refactor user service | ||
|
|
||
| Implement the login endpoint. | ||
| Validate request body. | ||
|
|
||
| * Add email notification service | ||
|
|
||
| Implements a new email notification module. | ||
|
|
||
| - Supports templating | ||
| - Supports HTML and plain text modes | ||
| - Includes retry logic |
There was a problem hiding this comment.
Is it really a good result?
* Refactor user service
...
- Supports templating
* (others...)
Not sure whether GitHub does so. Even if GitHub does so, I don't think GitHub was right or we need to blindly follow GitHub
There was a problem hiding this comment.
Sorry, I don't quite understand where the problem is. We add * before every commit message and - comes from the commit message content.
There was a problem hiding this comment.
For example:
commit1:
a
* a
* c
commit2:
x
* y
* z
The current code generates:
* a
* b
* c
* x
* y
* z
It looks like there are 6 commits.
But ideally it should be:
* a
* b
* c
* x
* y
* z
Just my opinion.
|
What's the difference of " Squash merge messages contain information about all commits by default. #35247 " ? Why 35247 seems more complex and changed more code. |
Gitea already supports including the commit messages of all commits for squash merge in #16134 and this behavior is controlled by the |
This comment was marked as outdated.
This comment was marked as outdated.
…nto Zettat123-improve-squash-message

This PR modifies the commit message format for squash merge to match GitHub's style.
Screenshots
Before:
After:
GitHub: