Skip to content

Use gomail library instead of gomail's smtp#36032

Closed
lunny wants to merge 2 commits into
go-gitea:mainfrom
lunny:lunny/mail
Closed

Use gomail library instead of gomail's smtp#36032
lunny wants to merge 2 commits into
go-gitea:mainfrom
lunny:lunny/mail

Conversation

@lunny
Copy link
Copy Markdown
Member

@lunny lunny commented Nov 26, 2025

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 26, 2025
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Nov 28, 2025

I see this is still importing go-mail/smtp, I assume all these imports will be removed in the end?

BTW not sure how feasible, but there is https://pkg.go.dev/net/smtp in the stdlib which should be enough for basic mail sending at least and less 3rd-party dependencies is always good.

@lunny
Copy link
Copy Markdown
Member Author

lunny commented Nov 29, 2025

I see this is still importing go-mail/smtp, I assume all these imports will be removed in the end?

BTW not sure how feasible, but there is pkg.go.dev/net/smtp in the stdlib which should be enough for basic mail sending at least and less 3rd-party dependencies is always good.

Good idea. I sent #36055 to replace this one.

@lunny lunny closed this Nov 29, 2025
@lunny lunny deleted the lunny/mail branch November 29, 2025 00:58
silverwind pushed a commit that referenced this pull request Dec 4, 2025
Replace #36032
Fix #36030

This PR use `net/smtp` instead of gomail's smtp. Now
github.com/wneessen/go-mail will be used only for generating email
message body.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request Dec 4, 2025
…36055)

Replace go-gitea#36032
Fix go-gitea#36030

This PR use `net/smtp` instead of gomail's smtp. Now
github.com/wneessen/go-mail will be used only for generating email
message body.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
silverwind pushed a commit that referenced this pull request Dec 4, 2025
…36083)

Backport #36055 by @lunny

Replace #36032
Fix #36030

This PR use `net/smtp` instead of gomail's smtp. Now
github.com/wneessen/go-mail will be used only for generating email
message body.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@xnox xnox mentioned this pull request Dec 7, 2025
pimpale pushed a commit to hud-evals/gitea that referenced this pull request Dec 14, 2025
…36055)

Replace go-gitea#36032
Fix go-gitea#36030

This PR use `net/smtp` instead of gomail's smtp. Now
github.com/wneessen/go-mail will be used only for generating email
message body.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants