Fix bug when updating user email#36058
Merged
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
Dec 1, 2025
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Dec 1, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Dec 2, 2025
Fix go-gitea#20390 We should use `ReplacePrimaryEmailAddress` instead of `AdminAddOrSetPrimaryEmailAddress` when modify user's email from admin panel. And also we need a database transaction to keep deletion and insertion succeed at the same time.
silverwind
pushed a commit
that referenced
this pull request
Dec 2, 2025
Backport #36058 by @lunny Fix #20390 We should use `ReplacePrimaryEmailAddress` instead of `AdminAddOrSetPrimaryEmailAddress` when modify user's email from admin panel. And also we need a database transaction to keep deletion and insertion succeed at the same time. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Contributor
|
I have some questions about this change:
|
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 2, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix bug when updating user email (go-gitea#36058) Add "Go to file", "Delete Directory" to repo file list page (go-gitea#35911) Replace `lint-go-gopls` with additional `govet` linters (go-gitea#36028) Fix Actions `pull_request.paths` being triggered incorrectly by rebase (go-gitea#36045)
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Dec 2, 2025
* origin/main: [skip ci] Updated translations via Crowdin Fix bug when updating user email (go-gitea#36058) Add "Go to file", "Delete Directory" to repo file list page (go-gitea#35911) Replace `lint-go-gopls` with additional `govet` linters (go-gitea#36028) Fix Actions `pull_request.paths` being triggered incorrectly by rebase (go-gitea#36045) Fix error handling in mailer and wiki services (go-gitea#36041) Update JS deps, fix deprecations (go-gitea#36040) Fix incorrect viewed files counter if file has changed (go-gitea#36009)
silverwind
pushed a commit
that referenced
this pull request
Dec 4, 2025
Follow #36058 for API edit user bug when editing email. - The Admin Edit User API includes a breaking change. Previously, when updating a user with an email from an unallowed domain, the request would succeed but return a warning in the response headers. Now, the request will fail and return an error in the response body instead. - Removed `AdminAddOrSetPrimaryEmailAddress` because it will not be used any where. Fix #36058 (comment) --------- Co-authored-by: Giteabot <teabot@gitea.io>
GiteaBot
added a commit
to GiteaBot/gitea
that referenced
this pull request
Dec 4, 2025
Follow go-gitea#36058 for API edit user bug when editing email. - The Admin Edit User API includes a breaking change. Previously, when updating a user with an email from an unallowed domain, the request would succeed but return a warning in the response headers. Now, the request will fail and return an error in the response body instead. - Removed `AdminAddOrSetPrimaryEmailAddress` because it will not be used any where. Fix go-gitea#36058 (comment) --------- Co-authored-by: Giteabot <teabot@gitea.io>
silverwind
pushed a commit
that referenced
this pull request
Dec 4, 2025
Backport #36068 by @lunny Follow #36058 for API edit user bug when editing email. - The Admin Edit User API includes a breaking change. Previously, when updating a user with an email from an unallowed domain, the request would succeed but return a warning in the response headers. Now, the request will fail and return an error in the response body instead. - Removed `AdminAddOrSetPrimaryEmailAddress` because it will not be used any where. Fix #36058 (comment) Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #20390
We should use
ReplacePrimaryEmailAddressinstead ofAdminAddOrSetPrimaryEmailAddresswhen modify user's email from admin panel. And also we need a database transaction to keep deletion and insertion succeed at the same time.