Skip to content

feat(debian): use explicit, stronger defaults for newly generated repo signing keys #36236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wxiaoguang merged 5 commits into from
Jan 1, 2026
Merged

feat(debian): use explicit, stronger defaults for newly generated repo signing keys #36236

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f454c22
feat(debian): generate keypair with username and stronger config
0xMax42 Dec 23, 2025
9938866
refactor: remove redundant RSA key size configuration
0xMax42 Dec 23, 2025
ded26da
refactor: remove username from keypair generation
0xMax42 Dec 24, 2025
abaaa09
Update services/packages/debian/repository.go
wxiaoguang Jan 1, 2026
6abb20c
Merge branch 'main' into feature/improve-debian-registry-key-generation
wxiaoguang Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion services/packages/debian/repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"bytes"
"compress/gzip"
"context"
"crypto"
"errors"
"fmt"
"io"
Expand Down Expand Up @@ -67,7 +68,14 @@ func GetOrCreateKeyPair(ctx context.Context, ownerID int64) (string, string, err
}

func generateKeypair() (string, string, error) {
e, err := openpgp.NewEntity("", "Debian Registry", "", nil)
// Repository signing keys are long-lived and there is currently no rotation mechanism, choose stronger algorithms
cfg := &packet.Config{
Comment thread
wxiaoguang marked this conversation as resolved.
RSABits: 4096,
DefaultHash: crypto.SHA256,
DefaultCipher: packet.CipherAES256,
}

e, err := openpgp.NewEntity("", "Automatically generated Debian Registry Key; created "+time.Now().UTC().Format(time.RFC3339), "", cfg)
if err != nil {
return "", "", err
}
Expand Down