Skip to content

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Jan 15, 2026

Next attempt for alpine 3.23 following #36185 and #36202.

Do not merge yet, I want to try if we can get this build to execute during docker-dryrun CI so that such main branch failures can be avoided in the future.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 15, 2026
@silverwind silverwind marked this pull request as draft January 15, 2026 08:41
@silverwind
Copy link
Member Author

silverwind commented Jan 24, 2026

I've now added the platforms to docker-dryun, same es in the release build, so these two docker builds should now do the exact same builds.

- name: build regular docker image
uses: docker/build-push-action@v6
with:
context: .
platforms: linux/amd64,linux/arm64,linux/riscv64
push: true
tags: ${{ steps.meta.outputs.tags }}
annotations: ${{ steps.meta.outputs.annotations }}

@silverwind silverwind marked this pull request as ready for review January 24, 2026 13:33
@silverwind silverwind changed the title Bump alpine to 3.23 Bump alpine to 3.23, add platforms to docker-dryrun Jan 24, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 24, 2026
@silverwind
Copy link
Member Author

silverwind commented Jan 24, 2026

BTW docker-dryrun is quite slow after this change (99minutes), but it's definitely necessary.

I think I can refactor the actions code that it only runs when Dockerfiles are modified, keeping the slowness impact to a minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants