Generate SVG assets at build time

[silverwind]

This generates the SVG asset directories before running webpack, eliminating the needs to have the output files checked into git and to run make svg after these dependency updates. The only downside is we can not see changes to the output files during review, but that's acceptable imho.

[silverwind]

Test failures indicate the backend may also have a dependency on the SVG assets, so likely we will need to alter make dependencies which will introduce the node dependency of the backend build.

[silverwind]

will introduce the node dependency of the backend build.

Actually I think it can be avoided. It's just that all tests have the dependency on the svg files and therefor node now, so I've added SVG_DEST to all the various tests targets.

[wxiaoguang]

As an IDE users, before:

• ./make watch-frontend
• click the "Start debugger" button in IDE to start backend

After: it needs one more step to build svg before starting the debugger?

[silverwind]

As an IDE users, before:

* ./make watch-frontend

* click the "Start debugger" button in IDE to start backend

After: it needs one more step to build svg before starting the debugger?

Should work like before, watch-frontend depends on SVG_DEST, so it will build the SVGs before starting webpack (if needed).

[silverwind]

After: it needs one more step to build svg before starting the debugger?

To further clarify: Backend does not have a dependency on pre-built SVGs, only tests have this dependency. In development they will be read from the file system and for the prod build it's guaranteed that the public assets are built before the backend is.

[wxiaoguang]

Backend does not have a dependency on pre-built SVGs,

Backend does need the pre-built SVGs, backend directly loads SVGs from public/assets/img/svg

Since this: Direct SVG rendering (#12157), https://github.com/go-gitea/gitea/pull/12157/files#diff-315287eed590655a2b96b78db333e10c824282a6764d25f5e13642a8c4386e3c

[silverwind]

Backend does need the pre-built SVGs, backend directly loads SVGs from public/assets/img/svg

Yes but it's not a requirement for them to exist before the backend dev server starts, it's fine if they are generated with a delay as part of watch-frontend.

[wxiaoguang]

Backend does need the pre-built SVGs, backend directly loads SVGs from public/assets/img/svg

Yes but it's not a requirement for them to exist before the backend dev server starts, it's fine if they are generated with a delay as part of watch-frontend.

It is a requirement for them to exist before the backend dev server stars , see mustInit(svg.Init)

[silverwind]

Hmm that complicates it. What exactly does click the "Start debugger" button in IDE to start backend do? Which command is ran? Does it run air? Maybe we need to commit some vscode config so that we can pass additional commands.

[wxiaoguang]

Hmm that complicates it. What exactly does click the "Start debugger" button in IDE to start backend do? Which command is ran? Does it run air?

Run the entry:

Details

---

BTW: I don't mean that it is a must that the assets must be ready before the server's first start. It can tell developers that the assets are missing and restart the server later. I only mean that backend server does need the assets to work.

[silverwind]

I'd say running main like that is not the recommended way to run the dev server which is still make watch. Maybe we should make make watch also start the debugger (I assume it's dlv?)

Aside that, vscode seems to allow some customization for the debugger startup. Maybe via a preloadTask, https://code.visualstudio.com/docs/debugtest/debugging-configuration#_launchjson-attributes.

But in any case, we need to fix make watch so it builds the SVGs first before starting backend build.

[wxiaoguang]

But in anycase, we need to fix make watch so it builds the SVGs first before starting backend build.

Yep, make watch is another problem.

SVG assets are different from JS/CSS assets. Backend can tolerate that JS/CSS assets are missing and load them later flawlessly (one flaw: theme list will be empty and use default theme). But if SVG assets are missing, the server need to restart to do reload.

---

Or, need to make backend code also tolerate SVG assets missing and support dynamic reloading

[wxiaoguang]

Maybe we should make make watch also start the debugger (I assume it's dlv?)

Goland debugger:

/.../GoLand.app/Contents/plugins/go-plugin/lib/dlv/macarm/dlv --listen=127.0.0.1:51166 --headless=true --api-version=2 --check-go-version=false --only-same-user=false exec /Users/user/work/gitea/gitea_web -- web #gosetup
API server listening at: 127.0.0.1:51166
...

[silverwind]

make backend code also tolerate SVG assets missing and support dynamic reloading

I guess we could remove this svgIcons "cache" variable and dynamically read from fs/embed.

gitea/modules/svg/svg.go

Line 17 in 2a56c4e

var svgIcons map[string]string

[Copilot]

Pull request overview

This PR automates SVG asset generation by integrating it into the build process. Instead of requiring manual make svg commands and checking generated files into git, SVG assets are now generated automatically as build dependencies.

Changes:

• Modified Makefile to generate SVG assets as a prerequisite for webpack, tests, and linting tasks
• Updated GitHub Actions workflows to install Node.js and pnpm for backend test jobs
• Removed the separate svg-check target that verified generated assets were committed

Reviewed changes

Copilot reviewed 2 out of 436 changed files in this pull request and generated 2 comments.

File	Description
Makefile	Added $(SVG_DEST) as a dependency to webpack, test targets, and linting tasks; removed svg-check target and converted svg to use make dependencies
.github/workflows/pull-db-tests.yml	Added pnpm and Node.js setup steps to all database test jobs to support SVG generation during builds

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.