Skip to content

Fix editorconfig not respected in PR Conversation view #36492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silverwind merged 4 commits into from
Jan 30, 2026
Merged

Fix editorconfig not respected in PR Conversation view #36492

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58c62f1
Initial plan
Copilot Jan 30, 2026
0160e02
Fix editorconfig not respected in PR Conversation view
Copilot Jan 30, 2026
9cfbec5
Apply suggestion from @silverwind
silverwind Jan 30, 2026
f1dd712
Merge branch 'main' into copilot/fix-issue-24991
silverwind Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions routers/web/web.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1229,7 +1229,7 @@ func registerWebRoutes(m *web.Router) {
m.Group("/{username}/{reponame}/{type:issues}", func() {
// these handlers also check unit permissions internally
m.Get("", repo.Issues)
m.Get("/{index}", repo.ViewIssue) // also do pull-request redirection (".../issues/{PR-number}" -> ".../pulls/{PR-number}")
m.Get("/{index}", repo.SetEditorconfigIfExists, repo.ViewIssue) // also do pull-request redirection (".../issues/{PR-number}" -> ".../pulls/{PR-number}")
Comment thread
silverwind marked this conversation as resolved.
Outdated
Comment thread
silverwind marked this conversation as resolved.
Outdated
}, optSignIn, context.RepoAssignment, context.RequireUnitReader(unit.TypeIssues, unit.TypePullRequests, unit.TypeExternalTracker))
// end "/{username}/{reponame}": issue list, issue view (pull-request redirection), external tracker

Expand Down Expand Up @@ -1530,7 +1530,7 @@ func registerWebRoutes(m *web.Router) {
m.Group("/{username}/{reponame}", func() {
m.Get("/{type:pulls}", repo.Issues)
m.Group("/{type:pulls}/{index}", func() {
m.Get("", repo.SetWhitespaceBehavior, repo.GetPullDiffStats, repo.ViewIssue)
m.Get("", repo.SetEditorconfigIfExists, repo.SetWhitespaceBehavior, repo.GetPullDiffStats, repo.ViewIssue)
m.Get(".diff", repo.DownloadPullDiff)
m.Get(".patch", repo.DownloadPullPatch)
m.Get("/merge_box", repo.ViewPullMergeBox)
Expand Down