fix(diff): reprocess htmx content after loading more files (#36568)#36577
Merged
wxiaoguang merged 4 commits intoFeb 10, 2026
Conversation
…36568) The "Show more files" button replaces `#diff-incomplete` with newly loaded diff file boxes. The inserted HTML may contain htmx attributes, but they are not processed after insertion. Wrap the incomplete diff placeholder with a temporary wrapper so we can call `htmx.process()` on the newly inserted content. After processing, unwrap the wrapper to keep the DOM structure unchanged. - Open a large PR diff page where `Diff.IsIncomplete` is true - Click "Show more files" - Verify newly loaded file boxes behave correctly (htmx-related features work as expected) <img width="927" height="278" alt="image" src="https://github.com/user-attachments/assets/54f2b4f2-c0e1-483c-9e26-79a2838e98ee" /> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Feb 10, 2026
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Feb 10, 2026
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Show more files" button replaces
#diff-incompletewith newly loaded diff file boxes.The inserted HTML may contain htmx attributes, but they are not processed after insertion.
Wrap the incomplete diff placeholder with a temporary wrapper so we can call
htmx.process()on the newly inserted content. After processing, unwrap the wrapper to keep the DOM structure unchanged.Diff.IsIncompleteis true