Skip to content

feat(db): Improve BuildCaseInsensitiveLike with lowercase #36598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silverwind merged 17 commits into from
Feb 14, 2026
Merged

feat(db): Improve BuildCaseInsensitiveLike with lowercase #36598

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
26fddc3
feat(db): case-insensitive LIKE/IN for PostgreSQL
tyroneyeh Feb 12, 2026
fc15486
Fix copilot
tyroneyeh Feb 12, 2026
8ffec35
fix(db): update BuildCaseInsensitiveLike for SQLite handling
tyroneyeh Feb 12, 2026
3efd021
Merge branch 'main' into main_pgCaseInsensitive
silverwind Feb 13, 2026
2d61b0a
fix(db): update case-insensitive functions to use LOWER for SQLite
tyroneyeh Feb 13, 2026
04dc671
fix(db): correct comment in BuildCaseInsensitiveLike for SQLite handling
tyroneyeh Feb 13, 2026
1781a32
fix(db): update BuildCaseInsensitiveIn to use strings.ToLower for cas…
tyroneyeh Feb 13, 2026
e37dcc9
fix(util): replace ToUpperASCII with ToLowerASCII and update tests fo…
tyroneyeh Feb 13, 2026
f755dd4
fix(tests): update lowerTests for consistent case handling in TestToL…
tyroneyeh Feb 13, 2026
5e7e05b
Copilot recommends removing the use of ilike in PostgreSQL
tyroneyeh Feb 13, 2026
43ca0cc
Remove PostgreSQL ILIKE comment in common.go
tyroneyeh Feb 13, 2026
db39ca3
fix
wxiaoguang Feb 13, 2026
ddbac8e
fix comment
wxiaoguang Feb 13, 2026
0071444
fix comment
wxiaoguang Feb 13, 2026
7f31c02
fix
wxiaoguang Feb 13, 2026
945f3a2
fix var name
wxiaoguang Feb 13, 2026
6ab807d
Merge branch 'main' into main_pgCaseInsensitive
silverwind Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions models/db/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,27 @@ import (
// Handles especially SQLite correctly as UPPER there only transforms ASCII letters.
func BuildCaseInsensitiveLike(key, value string) builder.Cond {
if setting.Database.Type.IsSQLite3() {
return builder.Like{"UPPER(" + key + ")", util.ToUpperASCII(value)}
return builder.Expr(key+" LIKE ? COLLATE NOCASE", value)
}
Comment thread
tyroneyeh marked this conversation as resolved.
Outdated
return builder.Like{"UPPER(" + key + ")", strings.ToUpper(value)}
if setting.Database.Type.IsPostgreSQL() {
return builder.Expr(key+" ILIKE ?", value)
}
return builder.Like{"LOWER(" + key + ")", strings.ToLower(value)}
Comment thread
tyroneyeh marked this conversation as resolved.
}

// BuildCaseInsensitiveIn returns a condition to check if the given value is in the given values case-insensitively.
// Handles especially SQLite correctly as UPPER there only transforms ASCII letters.
func BuildCaseInsensitiveIn(key string, values []string) builder.Cond {
uppers := make([]string, 0, len(values))
if setting.Database.Type.IsPostgreSQL() {
return builder.Expr(key+" ILIKE ANY (ARRAY[?])", values)
}
Comment thread
tyroneyeh marked this conversation as resolved.
Outdated
uppers := make([]string, len(values))
transform := strings.ToUpper
if setting.Database.Type.IsSQLite3() {
for _, value := range values {
uppers = append(uppers, util.ToUpperASCII(value))
}
} else {
for _, value := range values {
uppers = append(uppers, strings.ToUpper(value))
}
transform = util.ToUpperASCII
}
for i, value := range values {
uppers[i] = transform(value)
}

return builder.In("UPPER("+key+")", uppers)
Expand Down
2 changes: 1 addition & 1 deletion models/repo/user_repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ func GetRepoAssignees(ctx context.Context, repo *Repository) (_ []*user_model.Us
func GetIssuePostersWithSearch(ctx context.Context, repo *Repository, isPull bool, search string, isShowFullName bool) ([]*user_model.User, error) {
users := make([]*user_model.User, 0, 30)
var prefixCond builder.Cond = builder.Like{"lower_name", strings.ToLower(search) + "%"}
if isShowFullName {
if search != "" && isShowFullName {
prefixCond = prefixCond.Or(db.BuildCaseInsensitiveLike("full_name", "%"+search+"%"))
}

Expand Down
Loading