Fix state desync in ComboMarkdownEditor#36625
Merged
Merged
Conversation
Fixes go-gitea#24253 In scenario from the issue, after a tasklist checkbox is clicked, the tasklist code updated `.raw-content` in the DOM after POSTing to the server. Then when "Edit" is clicked the ComboMarkdownEditor is shown with a stale value. Fix this by always reading from `.raw-content`, no server syncronization necessary because the value in `.raw-content` is in sync with the server.
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
Feb 14, 2026
Fix typo in comments regarding server-side content changes.
lafriks
approved these changes
Feb 14, 2026
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Feb 16, 2026
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24253
When a tasklist checkbox is clicked, the tasklist code updates
.raw-contentwith latest server data in the DOM after POSTing.Then when "Edit" is clicked the ComboMarkdownEditor is shown with a stale value from the previous edit session.
The fix makes it always read from
.raw-content, no server syncronization necessary because the value in.raw-contentis the latest from the server.