Skip to content

Remove i18n backport tool at the moment because of translation format changed#36643

Merged
lunny merged 4 commits into
go-gitea:mainfrom
lunny:lunny/remove_backport_trans
Feb 17, 2026
Merged

Remove i18n backport tool at the moment because of translation format changed#36643
lunny merged 4 commits into
go-gitea:mainfrom
lunny:lunny/remove_backport_trans

Conversation

@lunny
Copy link
Copy Markdown
Member

@lunny lunny commented Feb 16, 2026

Starting with v1.26, Gitea uses a JSON configuration file format instead of the INI format used in v1.25 and earlier versions.

Because of this fundamental format change, a clean translation backport to the v1.25 branch (or earlier release branches) is not feasible.The recommended approach is:

  • Wait until the release/v1.26 branch is created after the official v1.26 release.
  • Then introduce a new JSON-based configuration (or migration/compatibility layer) on top of that branch.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 16, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 16, 2026
@silverwind
Copy link
Copy Markdown
Member

I searched the codebase for string locale_en-US.ini, found these, may worth updating to json too:

modules/gitrepo/commit_file_test.go:24:			output: "MM\x00options/locale/locale_en-US.ini\x00",
modules/gitrepo/commit_file_test.go:26:				"options/locale/locale_en-US.ini",
modules/gitrepo/commit_file_test.go:86:			output: "\x00MM\x00options/locale/locale_en-US.ini\x00",
modules/gitrepo/commit_file_test.go:88:				"options/locale/locale_en-US.ini",

@wxiaoguang
Copy link
Copy Markdown
Contributor

I searched the codebase for string locale_en-US.ini, found these, may worth updating to json too:

These are only test fixtures. They can use any filename. Ideally it should use "any-path/any-file.ext" to avoid misleading.

@lunny lunny changed the title Migrate backport i18n tool Remove i18n backport tool at the moment because of translation format changed Feb 17, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 17, 2026
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 17, 2026
@lunny lunny enabled auto-merge (squash) February 17, 2026 20:14
@lunny lunny merged commit b970cc0 into go-gitea:main Feb 17, 2026
24 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Feb 17, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 17, 2026
silverwind added a commit to silverwind/gitea that referenced this pull request Feb 17, 2026
* origin/main:
  Remove i18n backport tool at the moment because of translation format changed (go-gitea#36643)
  Fix bug the protected branch rule name is conflicted with renamed branch name (go-gitea#36650)
  Update JS deps (go-gitea#36656)
@lunny lunny deleted the lunny/remove_backport_trans branch February 17, 2026 22:58
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 18, 2026
… changed (go-gitea#36643)

Starting with v1.26, Gitea uses a JSON configuration file format instead
of the INI format used in v1.25 and earlier versions.

Because of this fundamental format change, a clean translation backport
to the v1.25 branch (or earlier release branches) is not feasible.The
recommended approach is:
- Wait until the release/v1.26 branch is created after the official
v1.26 release.
- Then introduce a new JSON-based configuration (or
migration/compatibility layer) on top of that branch.
@lunny lunny mentioned this pull request Feb 18, 2026
lunny added a commit that referenced this pull request Feb 20, 2026
@go-gitea go-gitea locked as resolved and limited conversation to collaborators May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants