Skip to content

Fix TestActionsCollaborativeOwner#36657

Merged
lunny merged 6 commits into
go-gitea:mainfrom
Zettat123:fix/fix-TestActionsCollaborativeOwner
Feb 17, 2026
Merged

Fix TestActionsCollaborativeOwner#36657
lunny merged 6 commits into
go-gitea:mainfrom
Zettat123:fix/fix-TestActionsCollaborativeOwner

Conversation

@Zettat123
Copy link
Copy Markdown
Contributor

In #32562, I incorrectly assigned mismatched repo_id values to the action_run and action_run_job fixtures used in TestActionsCollaborativeOwner. The changes introduced in #36173 will cause the test to fail. This PR removes the incorrect fixtures and switches to using mock workflows to test the relevant functionality.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 17, 2026
@ChristopherHX ChristopherHX self-requested a review February 17, 2026 18:49
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 17, 2026
Copy link
Copy Markdown
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1% more code covered by new test, probably because of repo creatin

@lunny lunny added type/bug reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Feb 17, 2026
@lunny lunny enabled auto-merge (squash) February 17, 2026 20:13
@lunny lunny merged commit 72ab59e into go-gitea:main Feb 17, 2026
24 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Feb 17, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 17, 2026
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 18, 2026
In go-gitea#32562, I incorrectly assigned mismatched `repo_id` values to the
`action_run` and `action_run_job` fixtures used in
`TestActionsCollaborativeOwner`. The changes introduced in go-gitea#36173 will
cause the test to fail. This PR removes the incorrect fixtures and
switches to using mock workflows to test the relevant functionality.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants