Add full-file expansion in diffs by silverwind · Pull Request #36663 · go-gitea/gitea

silverwind · 2026-02-17T20:54:10Z

New button in diff file headers to expand all collapsed sections in one click.

Changes

Backend:

ExcerptBlob returns JSON for both single and batch expand
excerptBlobExpandAll: single batch request reads blob once, highlights once via shared diffVarMutable pointers
MaxDisplayFileSize guard and 100-section cap to prevent OOM
parseBatchExcerptOptions uses FormStrings for repeated query params

Frontend:

Replace HTMX with unified JS fetch using data-global-click delegation
fetchBlobExcerpt: single-section expand with is-loading guard
onDiffExpandAll: batch expand via single request, collapse via saved innerHTML
Auto-flips expand-all button when all gaps are manually expanded

Tests:

E2e tests: expand-all, collapse, single expand, partial + batch, manual full expansion auto-flip

This PR was written with the help of Claude Opus 4.6

Add a per-file toggle button that expands all collapsed sections at once and can revert to the original collapsed state. The expand mechanism uses direct JS fetch instead of htmx, replacing the hx-get/hx-target attributes on code expander buttons with data-url. Individual expand buttons are also handled via JS delegated click handlers. The expand-all uses direction=full to make the backend expand entire gaps in a single response instead of chunk-by-chunk, significantly reducing the number of network round-trips for large files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: silverwind <me@silverwind.io>

…ve null guards Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

silverwind · 2026-02-19T01:30:34Z

Small margin-left added to copy button to provide some separation with the text, this is consistent with GitHub. Screenshot in PR description is updated.

wxiaoguang · 2026-02-19T02:35:57Z

// Loop: expand all collapsed sections until none remain.

For a file with 4000 lines (locale_en-US.json), each request expands 20 lines, then you sends 200 request to server in short time?

silverwind · 2026-02-19T02:55:19Z

Yeah the current mechanism is inefficient. I guess we could do more backend changes to make it send all at once.

When expanding all collapsed sections in a diff, the frontend now collects per-gap parameters from all expander buttons, joins them with commas, and makes a single GET request. The backend detects batch mode (comma in last_left), renders each section to HTML, and returns a JSON string array. Single-section expands are unchanged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

silverwind · 2026-02-20T05:24:46Z

Yeah the current mechanism is inefficient. I guess we could do more backend changes to make it send all at once.

Adressed in e643492.

wxiaoguang · 2026-02-20T06:22:05Z

Horrible AI code, duplicate every line in backend.

silverwind · 2026-02-20T06:25:46Z

Odd, I can make it deduplicate more, had already asked it to minimize the diff.

silverwind · 2026-04-10T18:40:43Z

Reworking this now. Plan is to replace the htmx-based fetch for single frequents with a json api that can return both single and all fragments as an array of html fragments. The full-file fetch will be a single fetch for all fragements in 1 call to the backend.

…e2e tests Backend: - ExcerptBlob returns JSON for both single and batch expand - Add excerptBlobExpandAll with MaxDisplayFileSize guard and 100-section cap - Use FormStrings for repeated query params instead of comma-separated - BuildBlobExcerptDiffSectionsFull: shared diffVarMutable pointers for single-pass highlighting across all sections - Keep ExcerptBlob nearly identical to main (4-line early return added) Frontend: - Replace HTMX with unified JS fetch using data-global-click delegation - Remove htmx.process calls and sleep(500) hack - fetchBlobExcerpt: single expand with is-loading guard - onDiffExpandAll: batch expand via single request, collapse via saved innerHTML, auto-flip button when all gaps manually expanded - State saved before is-loading class to avoid poisoning restored state Tests: - Add e2e tests: direct expand-all, collapse, single expand, partial manual + batch, manual full expansion auto-flip - Remove old integration tests replaced by e2e coverage - Update pull_commit_test for JSON response format Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind · 2026-04-10T21:34:33Z

Rewrite done:

htmx replaced with data-global-click
Backend logic condensed into excerptBlobExpandAll
Added E2E tests
All fetches are now JSON array of HTML instead of single HTML

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind · 2026-04-10T23:37:05Z

One more minor enhancement added: All expand buttons now set aria-label and the e2e tests use those labels to select them.

wxiaoguang

Horrible AI slop and duplicate code.

Need to rewrite most of them (if I would have some time, but I can't promise)

silverwind · 2026-04-11T08:19:52Z

I backfed all your vague feedback into it when producing this. Next time give specific feedback what you want and we might get something you like.

wxiaoguang · 2026-04-11T11:59:45Z

Duplicate code, fragile logic, etc.

I don't want to spend more time on teaching AI on this topic, which would cost multiple times of time than I do it by myself (to be clear: I also use AI, and will be assisted by AI).

Indeed there are also workarounds: just click the "View File", and/or "Blame" the file. "Full-file expansion in diff" seems to be a rare use case during code review (in most cases, people don't really need to read the unchanged parts)

Since it is just a nice-to-have feature, it doesn't block any real world user and no requirement issue from end users, so either someone can make it overall right, or when I have some free time and get interest to clean up the AI slop.

silverwind · 2026-04-11T12:14:18Z

Give clear actionable sentence or 2 how you want the design to look. That would have taken you less time than writing that last comment and would be actually helpful.

"Unclean code" without actionable feedback is not a valid reason for a rejection imho when the code demonstrably works, and has 100% test coverage.

The repo is full of unclean code because of years of careless rubberstamping, why should my PRs be treated differently now?

wxiaoguang · 2026-04-11T12:15:41Z

The repo is full of unclean code because of years of careless rubberstamping, why should my PRs be treated differently now?

No, not "differently". I always block rubberstamp approvals of the PRs which still have problems, including this one.

TheFox0x7

Take it with a grain of salt as I have no experience with this part of codebase:

ExcerptBlob and excerptBlobExpandAll are basically the same function.
IMO io.Reader should be passed down to the function instead read in the expandAll one. You get more consistent apis that way.

I'm also not sure if it wouldn't be easier to ask git for this content directly by telling git to expand context for the diff but I did not have an occasion to dig into gitea's compare systems.

Also I can't use this on files that have their diff hidden by default, despite being able to request that diff.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+		// Determine line range: 1-indexed inclusive
+		startLine := opts.LastRight + 1
+		endLine := opts.RightIndex - 1 // between-hunk: stop before next hunk
+		if opts.LeftHunkSize == 0 && opts.RightHunkSize == 0 {
+			endLine = len(allLines) // EOF: expand to end of file
+		}
+
+		leftStart := opts.LastLeft + 1
+		var diffLines []*DiffLine
+		for lineNum := startLine; lineNum <= endLine; lineNum++ {
+			lineIdx := lineNum - 1 // 0-indexed
+			if lineIdx >= len(allLines) {
+				break


+  btn.classList.add('is-loading', 'loading-icon-2px');
+  try {
+    const response = await GET(btn.getAttribute('data-url')!);
+    if (!response.ok) return;
+
+    tr.insertAdjacentHTML('afterend', await response.json());
+    tr.remove();
+


GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2026

silverwind added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 17, 2026

silverwind requested a review from Copilot February 17, 2026 20:56

github-actions Bot added modifies/go labels Feb 17, 2026

This comment was marked as outdated.

Sign in to view

Apply suggestion from @Copilot

d00a608

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: silverwind <me@silverwind.io>

Copilot started reviewing on behalf of silverwind February 17, 2026 21:26 View session

wxiaoguang reviewed Feb 18, 2026

View reviewed changes

Comment thread services/gitdiff/gitdiff.go Outdated

wxiaoguang reviewed Feb 18, 2026

View reviewed changes

Comment thread web_src/js/features/repo-diff.ts Outdated

wxiaoguang reviewed Feb 18, 2026

View reviewed changes

Comment thread web_src/js/features/repo-diff.ts Outdated

silverwind and others added 7 commits February 18, 2026 07:28

Address review comments: use data-global-click, Map with box id, remo…

de60beb

…ve null guards Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Use showTemporaryTooltip to re-render tooltip on expand/collapse

267b7bf

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Use non-null assertions for guaranteed tooltip attributes

0fc9c4e

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Compress code and add error handling for fetchBlobExcerpt

c8b2dcd

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Revert error handling in fetchBlobExcerpt

49624d2

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Merge branch 'main' into fullexpand

5af02f2

add margin-left to first button

a93cb3a

wxiaoguang marked this pull request as draft February 19, 2026 09:42

silverwind and others added 2 commits February 20, 2026 04:55

Merge branch 'main' into fullexpand

e86f2ff

silverwind marked this pull request as ready for review February 20, 2026 05:23

silverwind mentioned this pull request Apr 10, 2026

Remove htmx #37079

Closed

silverwind and others added 2 commits April 10, 2026 20:47

Merge branch 'main' into fullexpand

161daab

silverwind changed the title ~~Add full-file expansion in diff blocks~~ Add full-file expansion in diffs Apr 10, 2026

silverwind marked this pull request as ready for review April 10, 2026 21:34

silverwind and others added 2 commits April 10, 2026 23:44

Extract batch section limit to named constant

197ae3f

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

extract apiUpdateFile util

0b152cc

silverwind requested a review from wxiaoguang April 10, 2026 22:03

silverwind and others added 2 commits April 11, 2026 00:12

Use Playwright APIResponse type instead of custom ApiResponse

d326431

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

cleanup ts

43cf399

lunny approved these changes Apr 10, 2026

View reviewed changes

silverwind and others added 2 commits April 11, 2026 01:04

button styling tweaks

60d329c

Add aria-labels to diff expand buttons, use semantic selectors in e2e

e8ce635

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

wxiaoguang requested changes Apr 11, 2026

View reviewed changes

TheFox0x7 reviewed Apr 11, 2026

View reviewed changes

lunny removed modifies/templates labels Apr 19, 2026

silverwind marked this pull request as draft April 23, 2026 08:35

silverwind requested a review from Copilot May 6, 2026 02:50

Copilot started reviewing on behalf of silverwind May 6, 2026 02:51 View session

Copilot AI reviewed May 6, 2026

View reviewed changes

lunny mentioned this pull request Jul 28, 2026

feat(diff): add a button to expand all hidden lines of a diff file #38675

Open

Uh oh!

Uh oh!

Conversation

silverwind commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

silverwind commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Feb 19, 2026

Uh oh!

silverwind commented Feb 19, 2026

Uh oh!

silverwind commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Feb 20, 2026

Uh oh!

silverwind commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 10, 2026

Uh oh!

wxiaoguang left a comment

Choose a reason for hiding this comment

Uh oh!

silverwind commented Apr 11, 2026

Uh oh!

wxiaoguang commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheFox0x7 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

silverwind commented Feb 17, 2026 •

edited

Loading

silverwind commented Feb 19, 2026 •

edited

Loading

silverwind commented Feb 20, 2026 •

edited

Loading

silverwind commented Feb 20, 2026 •

edited

Loading

silverwind commented Apr 10, 2026 •

edited

Loading

silverwind commented Apr 10, 2026 •

edited

Loading

wxiaoguang commented Apr 11, 2026 •

edited

Loading

silverwind commented Apr 11, 2026 •

edited

Loading

wxiaoguang commented Apr 11, 2026 •

edited

Loading