Skip to content

Add “Copy Source” to markup comment menu #36726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wxiaoguang merged 19 commits into from
Mar 1, 2026
Merged

Add “Copy Source” to markup comment menu #36726

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
d5b852b
gitea: add 'Copy Source' option to issue context menu
shafi-VM Feb 23, 2026
e336f67
Merge branch 'main' into add-copy-source-button
shafi-VM Feb 23, 2026
015becf
gitea: read comment source from existing raw-content element
shafi-VM Feb 23, 2026
b428c26
fix
wxiaoguang Feb 23, 2026
d13f4c1
fine tune
wxiaoguang Feb 23, 2026
d14adde
fine tune
wxiaoguang Feb 23, 2026
f4c78cd
fix copy tooltip hiding on fomantic dropdowns
silverwind Feb 24, 2026
c7eec32
typo
silverwind Feb 24, 2026
00014b1
Apply suggestion from @silverwind
silverwind Feb 24, 2026
54a1a24
gitea: typo
shafi-VM Feb 24, 2026
eddd997
handle empty comment and refactor away variable
silverwind Feb 24, 2026
608e091
update copy source disabled state after editing comment
silverwind Feb 24, 2026
8404880
Apply suggestion from @silverwind
silverwind Feb 24, 2026
b3648a8
Apply suggestion from @silverwind
silverwind Feb 24, 2026
4da90e2
Apply suggestion from @silverwind
silverwind Feb 24, 2026
2a2fca7
update comment
silverwind Feb 24, 2026
f45010c
Merge branch 'main' into add-copy-source-button
silverwind Feb 28, 2026
5ce123d
Remove disabled state from "Copy Source" context menu item
silverwind Feb 28, 2026
14053e1
Merge branch 'main' into add-copy-source-button
wxiaoguang Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions options/locale/locale_en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1524,6 +1524,7 @@
"repo.issues.commented_at": "commented <a href=\"#%s\">%s</a>",
"repo.issues.delete_comment_confirm": "Are you sure you want to delete this comment?",
"repo.issues.context.copy_link": "Copy Link",
"repo.issues.context.copy_source": "Copy Source",
"repo.issues.context.quote_reply": "Quote Reply",
"repo.issues.context.reference_issue": "Reference in New Issue",
"repo.issues.context.edit": "Edit",
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/diff/comments.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
<span class="no-content">{{ctx.Locale.Tr "repo.issues.no_content"}}</span>
{{end}}
</div>
<div id="issuecomment-{{.ID}}-raw" class="raw-content tw-hidden">{{.Content}}</div>
<div id="{{.HashTag}}-raw" class="raw-content tw-hidden">{{.Content}}</div>
<div class="edit-content-zone tw-hidden" data-update-url="{{$.root.RepoLink}}/comments/{{.ID}}" data-content-version="{{.ContentVersion}}" data-context="{{$.root.RepoLink}}" data-attachment-url="{{$.root.RepoLink}}/comments/{{.ID}}/attachments"></div>
{{if .Attachments}}
{{template "repo/issue/view_content/attachments" dict "Attachments" .Attachments "RenderedContent" .RenderedContent}}
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/issue/view_content.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
<span class="no-content">{{ctx.Locale.Tr "repo.issues.no_content"}}</span>
{{end}}
</div>
<div id="issue-{{.Issue.ID}}-raw" class="raw-content tw-hidden">{{.Issue.Content}}</div>
<div id="{{.Issue.HashTag}}-raw" class="raw-content tw-hidden">{{.Issue.Content}}</div>
<div class="edit-content-zone tw-hidden" data-update-url="{{$.RepoLink}}/issues/{{.Issue.Index}}/content" data-content-version="{{.Issue.ContentVersion}}" data-context="{{.RepoLink}}" data-attachment-url="{{$.RepoLink}}/issues/{{.Issue.Index}}/attachments" data-view-attachment-url="{{$.RepoLink}}/issues/{{.Issue.Index}}/view-attachments"></div>
{{if .Issue.Attachments}}
{{template "repo/issue/view_content/attachments" dict "Attachments" .Issue.Attachments "RenderedContent" .Issue.RenderedContent}}
Expand Down
4 changes: 2 additions & 2 deletions templates/repo/issue/view_content/comments.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
<span class="no-content">{{ctx.Locale.Tr "repo.issues.no_content"}}</span>
{{end}}
</div>
<div id="issuecomment-{{.ID}}-raw" class="raw-content tw-hidden">{{.Content}}</div>
<div id="{{.HashTag}}-raw" class="raw-content tw-hidden">{{.Content}}</div>
<div class="edit-content-zone tw-hidden" data-update-url="{{$.RepoLink}}/comments/{{.ID}}" data-content-version="{{.ContentVersion}}" data-context="{{$.RepoLink}}" data-attachment-url="{{$.RepoLink}}/comments/{{.ID}}/attachments"></div>
{{if .Attachments}}
{{template "repo/issue/view_content/attachments" dict "Attachments" .Attachments "RenderedContent" .RenderedContent}}
Expand Down Expand Up @@ -432,7 +432,7 @@
<span class="no-content">{{ctx.Locale.Tr "repo.issues.no_content"}}</span>
{{end}}
</div>
<div id="issuecomment-{{.ID}}-raw" class="raw-content tw-hidden">{{.Content}}</div>
<div id="{{.HashTag}}-raw" class="raw-content tw-hidden">{{.Content}}</div>
<div class="edit-content-zone tw-hidden" data-update-url="{{$.RepoLink}}/comments/{{.ID}}" data-content-version="{{.ContentVersion}}" data-context="{{$.RepoLink}}" data-attachment-url="{{$.RepoLink}}/comments/{{.ID}}/attachments"></div>
{{if .Attachments}}
{{template "repo/issue/view_content/attachments" dict "Attachments" .Attachments "RenderedContent" .RenderedContent}}
Expand Down
1 change: 1 addition & 0 deletions templates/repo/issue/view_content/context_menu.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
{{$referenceUrl = printf "%s/files#%s" ctx.RootData.Issue.Link .item.HashTag}}
{{end}}
<div class="item context js-aria-clickable" data-clipboard-text-type="url" data-clipboard-text="{{$referenceUrl}}">{{ctx.Locale.Tr "repo.issues.context.copy_link"}}</div>
<div class="item context js-aria-clickable {{if not .item.Content}}disabled{{end}}" data-clipboard-target="#{{.item.HashTag}}-raw">{{ctx.Locale.Tr "repo.issues.context.copy_source"}}</div>
{{if ctx.RootData.IsSigned}}
{{$needDivider := false}}
{{if not ctx.RootData.Repository.IsArchived}}
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/issue/view_content/conversation.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ The variables in "ctx.Data" are different in each case, making this template fra
<span class="no-content">{{ctx.Locale.Tr "repo.issues.no_content"}}</span>
{{end}}
</div>
<div id="issuecomment-{{.ID}}-raw" class="raw-content tw-hidden">{{.Content}}</div>
<div id="{{.HashTag}}-raw" class="raw-content tw-hidden">{{.Content}}</div>
<div class="edit-content-zone tw-hidden" data-update-url="{{$.RepoLink}}/comments/{{.ID}}" data-content-version="{{.ContentVersion}}" data-context="{{$.RepoLink}}" data-attachment-url="{{$.RepoLink}}/comments/{{.ID}}/attachments"></div>
{{if .Attachments}}
{{template "repo/issue/view_content/attachments" dict "Attachments" .Attachments "RenderedContent" .RenderedContent}}
Expand Down
16 changes: 12 additions & 4 deletions web_src/js/features/clipboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,26 @@ const {copy_success, copy_error} = window.config.i18n;

// Enable clipboard copy from HTML attributes. These properties are supported:
// - data-clipboard-text: Direct text to copy
// - data-clipboard-target: Holds a selector for a <input> or <textarea> whose content is copied
// - data-clipboard-target: Holds a selector for an element. "value" of <input> or <textarea>, or "textContent" of <div> will be copied
// - data-clipboard-text-type: When set to 'url' will convert relative to absolute urls
export function initGlobalCopyToClipboardListener() {
document.addEventListener('click', async (e) => {
const target = (e.target as HTMLElement).closest('[data-clipboard-text], [data-clipboard-target]');
if (!target) return;
if (!target || target.classList.contains('disabled')) return;

e.preventDefault();

let text = target.getAttribute('data-clipboard-text');
if (!text) {
text = document.querySelector<HTMLInputElement>(target.getAttribute('data-clipboard-target')!)?.value ?? null;
if (text === null) {
const textSelector = target.getAttribute('data-clipboard-target')!;
const textTarget = document.querySelector(textSelector)!;
if (textTarget.nodeName === 'INPUT' || textTarget.nodeName === 'TEXTAREA') {
text = (textTarget as HTMLInputElement | HTMLTextAreaElement).value;
} else if (textTarget.nodeName === 'DIV') {
text = textTarget.textContent;
} else {
throw new Error(`Unsupported element for clipboard target: ${textSelector}`);
}
}

if (text && target.getAttribute('data-clipboard-text-type') === 'url') {
Expand Down
2 changes: 2 additions & 0 deletions web_src/js/features/repo-issue-edit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ async function tryOnEditContent(e: Event) {
renderContent = newRenderContent;

rawContent.textContent = comboMarkdownEditor.value();
// update "Copy Source" menu item disabled state
Comment thread
silverwind marked this conversation as resolved.
Outdated
document.querySelector(`[data-clipboard-target="#${rawContent.id}"]`)?.classList.toggle('disabled', !comboMarkdownEditor.value());
Comment thread
silverwind marked this conversation as resolved.
Outdated
Comment thread
silverwind marked this conversation as resolved.
Outdated

if (!commentContent.querySelector('.dropzone-attachments')) {
if (data.attachments !== '') {
Expand Down
9 changes: 9 additions & 0 deletions web_src/js/modules/tippy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ export function showTemporaryTooltip(target: Element, content: Content): void {
tooltipTippy.setContent(content);
tooltipTippy.setProps({getReferenceClientRect: () => refClientRect});
if (!tooltipTippy.state.isShown) tooltipTippy.show();

tooltipTippy.setProps({
onHidden: (tippy) => {
// reset the default tooltip content, if no default, then this temporary tooltip could be destroyed
Expand All @@ -208,6 +209,14 @@ export function showTemporaryTooltip(target: Element, content: Content): void {
}
},
});

// on elements where the tooltip is re-located like "Copy Link" inside fomantic dropdowns, tippy.js gets
// no mouseOut event and the tooltip stays visible, hide it with timeout.
Comment thread
silverwind marked this conversation as resolved.
Outdated
if (!popupTippyId) {
setTimeout(() => {
if (tooltipTippy.state.isVisible) tooltipTippy.hide();
}, 1500);
}
}

export function getAttachedTippyInstance(el: Element): Instance | null {
Expand Down
Loading