Feature non-zipped actions artifacts (action v7 / nodejs / npm v6.2.0)

[ChristopherHX]

• content_encoding contains a slash => v4 artifact
• updated proto files to support mime_type and no longer return errors for upload-artifact v7
• json and txt files are now previewed in browser
• normalized content-disposition header creation
• azure blob storage uploads directly in servedirect mode (no proxying data)
• normalize content-disposition headers based on go mime package
  • getting both filename and filename* encoding is done via custom code

Closes #36829

---

• Depends on something similar to Refactor storage content-type handling of ServeDirectURL #36804 to work reliable for ServeDirect
• Write test for content-type download + correctly do this for minio and azure
• Refactor mime handing in URL method of blobstorage ( #37975 )
• Move mime handling of azure out of this PR Refactor storage content-type handling of ServeDirectURL #36804
• Move support upload without Content-Length Header out of this PR Fix artifacts v4 backend upload problems #36805
• Move support single block uploads without blockmap out of this PR Fix artifacts v4 backend upload problems #36805
• Remove allow MakeRequest to call minio/azurerite and do special handling for serve direct? Or Move into it's own PR
• Learn more about content security to at least load inline css from html reports to display GitHub's example correctly
• Set Correct csp header for servedirect

[ChristopherHX]

GITHUB_SERVER_URL hack + @actions/artifact can be used like

           const { default: artifact } = await import("@actions/artifact");
           var artifactName = "my-single-file";
           process.env.GITHUB_SERVER_URL = "https://github.com" // Escape isGHES bomb
           var uploadResult = await artifact.uploadArtifact(
             artifactName,
             ['package.json'],
             './',
             {skipArchive: true}
           )

[Copilot]

Pull request overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 5 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[wxiaoguang]

Good enough now?

[ChristopherHX]

Is it ok to set charset to every file type?

    --- FAIL: TestActionsArtifactV4DownloadSingle/Download-Zip (0.01s)
        api_actions_artifact_v4_test.go:586: 
            	Error Trace:	/home/runner/work/gitea/gitea/tests/integration/api_actions_artifact_v4_test.go:586
            	Error:      	Not equal: 
            	            	expected: "application/zip"
            	            	actual  : "application/zip; charset=utf-8"
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1 +1 @@
            	            	-application/zip
            	            	+application/zip; charset=utf-8
            	Test:       	TestActionsArtifactV4DownloadSingle/Download-Zip

for text types in the test good point, but otherwise?

[wxiaoguang]

Is it ok to set charset to every file type?

Bug, fixed in new commit

[wxiaoguang]

Found more problems in the "httplib.ServeXxx" functions, fixed together.

[ChristopherHX]

Are you sure we should do something like this:

func (b *Base) SetServeHeaders(opt *ServeHeaderOptions) {
	httplib.ServeSetHeaders(b.Resp, *(*httplib.ServeHeaderOptions)(opt))
}

// ServeContent serves content to http request
func (b *Base) ServeContent(r io.ReadSeeker, opts *ServeHeaderOptions) {
	httplib.ServeSetHeaders(b.Resp, *(*httplib.ServeHeaderOptions)(opts))
	http.ServeContent(b.Resp, b.Req, opts.Filename, opts.LastModified, r)

This reads like a panic bomb if opt / opts is nil that is not type checked by golang.

I would rather do one of

• 1. also convert opts to a value here
• 2. do a nil check

[wxiaoguang]

Are you sure we should do something like this:
This reads like a panic bomb if opt / opts is nil that is not type checked by golang.

That part of code has been there for long time, and the opts can't be nil, so far so good.

Changing them will cause more changes in this PR, since it is not necessary, we can leave them to the future.

Actually these func (b *Base) xxx functions and type-alias type ServeHeaderOptions httplib.ServeHeaderOptions should be removed in the future, they were just introduced to help refactoring messy code in history. Make repository response support HTTP range request (#24592)

[ChristopherHX]

That part of code has been there for long time, and the opts can't be nil, so far so good.

Ok, yes everyone passes a non nil pointer, I think now this is mergeable as the last failing test is expected to pass now

[wxiaoguang]

Are you sure we should do something like this:
This reads like a panic bomb if opt / opts is nil that is not type checked by golang.

That part of code has been there for long time, and the opts can't be nil, so far so good.

Changing them will cause more changes in this PR, since it is not necessary, we can leave them to the future.

Actually these func (b *Base) xxx functions and type-alias type ServeHeaderOptions httplib.ServeHeaderOptions should be removed in the future, they were just introduced to help refactoring messy code in history. Make repository response support HTTP range request (#24592)

Done by AI : refactor: use value semantics for ServeHeaderOptions parameters #36982