Skip to content

Fix dump release asset bug #36799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lunny merged 7 commits into from
Mar 5, 2026
Merged

Fix dump release asset bug #36799

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c6937ed
Fix dump release asset bug
lunny Mar 2, 2026
707fc17
fix
lunny Mar 2, 2026
a228303
inline the change
lunny Mar 2, 2026
2d432e0
Merge branch 'main' into lunny/fix_dump_rel_asset
lunny Mar 2, 2026
2b0758d
Merge branch 'main' into lunny/fix_dump_rel_asset
GiteaBot Mar 5, 2026
36f138a
Merge branch 'main' into lunny/fix_dump_rel_asset
GiteaBot Mar 5, 2026
f09147c
Merge branch 'main' into lunny/fix_dump_rel_asset
GiteaBot Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion services/migrations/dump.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,9 @@ func (g *RepositoryDumper) CreateReleases(_ context.Context, releases ...*base.R
return err
}
for _, asset := range release.Assets {
attachLocalPath := filepath.Join(attachDir, asset.Name)
p := uuid.New().String()
// we cannot use asset.Name because it might contains special characters.
attachLocalPath := filepath.Join(attachDir, p)

// SECURITY: We cannot check the DownloadURL and DownloadFunc are safe here
// ... we must assume that they are safe and simply download the attachment
Expand Down