Enable eslint concurrency#36878
Merged
Merged
Conversation
Add `--concurrency 2` to all ESLint invocations in the Makefile. ESLint v9 supports multi-threaded linting, and benchmarking shows `--concurrency 2` provides the best wall-time improvement with reasonable CPU overhead. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
GiteaBot
added
the
lgtm/need 2
silverwind
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds --concurrency 2 to all four ESLint invocations in the Makefile to enable multi-threaded linting via ESLint's worker threads support. Based on the benchmark data provided, concurrency of 2 provides optimal wall-time improvement (~18% faster) while keeping CPU overhead reasonable.
Changes:
- Added
--concurrency 2flag to all ESLint commands in the Makefile (lint-js,lint-js-fix,lint-json,lint-json-fix)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
lunny
approved these changes
Mar 10, 2026
GiteaBot
added
lgtm/need 1
TheFox0x7
approved these changes
Mar 10, 2026
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 13, 2026
* giteaofficial/main: Bound PageSize in `ListUnadoptedRepositories` (go-gitea#36884) Fix timeline event layout overflow with long content (go-gitea#36595) [skip ci] Updated translations via Crowdin Replace index with id in actions routes (go-gitea#36842) Enable eslint concurrency (go-gitea#36878)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--concurrency 2to all ESLint invocations in the Makefile. ESLint v9 supports multi-threaded linting via worker threads. Benchmark results on a 16-core machine with ~211 lintable files:This PR was authored by Claude.