Allow text selection on checkbox labels#36970
Merged
wxiaoguang merged 5 commits intoMar 25, 2026
Merged
Conversation
Remove user-select: none from checkbox labels and instead prevent double-click text selection via mousedown event handler. This allows users to select label text by click-drag while preventing accidental selection on double-click. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
GiteaBot
added
the
lgtm/need 2
Only prevent double-click (detail === 2) word selection, not triple-click (detail === 3) line selection. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
silverwind
commented
Mar 24, 2026
Signed-off-by: silverwind <me@silverwind.io>
Member
Author
|
If preferred, we could also just remove the JS completely here. |
silverwind
commented
Mar 24, 2026
Signed-off-by: silverwind <me@silverwind.io>
Member
Author
|
Decided to remove the JS, it's too finicky. So this is a trivial 1-line change now. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to allow text selection on checkbox labels by removing the CSS rule that prevented selecting label text.
Changes:
- Removed
user-select: nonefrom.ui.checkbox labelstyling to allow label text selection.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lunny
approved these changes
Mar 24, 2026
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Mar 25, 2026
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
user-select: nonefrom checkbox labels to allow text selection which is sometimes useful.