Fix org contact email not clearable once set

[bircni]

When the email field was submitted as empty in org settings (web and API), the previous guard if form.Email != "" silently skipped the update, making it impossible to remove a contact email after it was set.

[wxiaoguang]

Actually .... you only need a few lines like

Email *string `json:"email" binding:"MaxSize(255)"`  (or Optional)

if form.Email != nil {
}

and you don't need that complex tests .....

AI really tends to make things unnecessary complex.

[wxiaoguang]

Dismissed the nonsense AI reviews #36975 (review)

AI vs AI, more slop

[bircni]

I am Not ready 😭 it's still WIP

[wxiaoguang]

I have told @silverwind many times: don't ask AI to review if the PR is not ready or good enough, for example:

• Add pull request files line selections #36014 (comment)
• Feat add Get pull requests associated to a commit's SHA #36617 (comment)
• Add code suggestion for PR review comments #36457 (comment)

It only wastes time.

[silverwind]

I use those reviews to get a general feeling about a PR. Copilot reviews are not to be taken too seriously, often it latches onto useless stuff.

[wxiaoguang]

I use those reviews to get a general feeling about a PR. Copilot reviews are not to be taken too seriously, often it latches onto useless stuff.

But almost all authors have been misled by your AI reviews, the latest one, 10 minutes ago:

• Add archived repository filters to global code search #36968 (comment)

Please you tell authors that don't trust the AI reviews, don't follow the AI slop

[wxiaoguang]

I use those reviews to get a general feeling about a PR. Copilot reviews are not to be taken too seriously, often it latches onto useless stuff.

You can also just use your local AI tools to review, don't pollute the GitHub review history.

[bircni]

@wxiaoguang what do you think - is that ok?

[wxiaoguang]

Can we have a common function like user_service.UpdateOrgEmailAddress(ctx, org, *form.Email)?

(Forget whether there is "org_service" package, if there is, it's the better package for the function)

[bircni]

Can we have a common function like user_service.UpdateOrgEmailAddress(ctx, org, *form.Email)?

(Forget whether there is "org_service" package, if there is, it's the better package for the function)

done yes it exists

[wxiaoguang]

Made more changes and fixed TODO: make EditOrgOption fields optional after https://gitea.com/go-chi/binding/pulls/5 got merged

[bircni]

@lunny can we Backport?

[wxiaoguang]

It should focus on releasing 1.26

If you really need to backport:

• If there is no conflict, then backport by cherrypick
• If there are conflicts, backport doesn't need to be the same as the complete fix, you can only backport the minimal change. e.g.: only change a few lines.

---