add valid github scopes#36977
Merged
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
lunny
reviewed
Mar 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds compatibility for GitHub Actions permissions: scopes so Gitea’s workflow permission parsing doesn’t panic when encountering GitHub-supported (but Gitea-unsupported) scopes, and introduces a regression test to cover those scope names.
Changes:
- Treat several GitHub-supported
permissionsscopes as explicit no-ops instead of triggeringPanicInDevOrTesting. - Add a test that parses a YAML permissions mapping containing all currently documented GitHub scopes to ensure parsing doesn’t panic.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| services/actions/permission_parser.go | Adds a no-op switch case list for GitHub-only scopes (e.g. security-events) to prevent panics. |
| services/actions/permission_parser_test.go | Adds a test enumerating GitHub-supported scopes to ensure the parser accepts them without panicking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wxiaoguang
approved these changes
Mar 24, 2026
GiteaBot
added
lgtm/need 1
Zettat123
approved these changes
Mar 24, 2026
GiteaBot
added
lgtm/done
bircni
approved these changes
Mar 24, 2026
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test for github supported scopes with test to ensure all of them work and don't panic
fixes: #36967