Add e2e reaction test, improve accessibility, enable parallel testing#37081
Merged
silverwind merged 12 commits intoApr 3, 2026
Conversation
Add a new e2e test for toggling issue reactions via the reaction picker dropdown. Extract `randomString` utility to replace ad-hoc `Date.now()` and `Math.random()` ID generation across all e2e tests, fixing potential name collisions when tests run in parallel workers. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
Apr 2, 2026
Improves accessibility by adding an `aria-label` to the reaction picker dropdown, making it identifiable by screen readers and semantic test selectors. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
Add `role="group"` with `aria-label="Reactions"` to the reactions container and include the reaction key in each button's aria-label. Update the e2e test to use semantic selectors. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
Replace crypto-based hex generation with simple alphanumeric character selection, and reuse `randomString` in `generatePassword`. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
Replace randomString calls with deterministic names derived from the test name. Remove randomString, generatePassword, and unused clickDropdownItem from e2e utils. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
silverwind
changed the title
randomString utilityThis reverts commit 4851ff6.
This reverts commit 27a9b12.
Enable fullyParallel and run chromium+firefox simultaneously. Add randomString suffixes to all test identifiers for concurrency safety. Parallelize login and API setup where possible. Use dedicated user in user-settings test to avoid admin state races. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
silverwind
changed the title
Member
Author
|
Now using Total |
lunny
approved these changes
Apr 3, 2026
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Apr 3, 2026
| @@ -1,5 +1,5 @@ | |||
| {{if ctx.RootData.IsSigned}} | |||
| <div class="item action ui dropdown jump pointing top right select-reaction" data-action-url="{{.ActionURL}}"> | |||
| <div class="item action ui dropdown jump pointing top right select-reaction" data-action-url="{{.ActionURL}}" aria-label="{{ctx.Locale.Tr "repo.add_reaction"}}"> | |||
Contributor
There was a problem hiding this comment.
Written by AI? Why here is "Add reaction" but not "Reactions"?
Member
Author
There was a problem hiding this comment.
It is this button:
It also has a toggle behaviour so can remove reactions as well, so you are right the label is not accurate. I have plans for this button to make it more like GitHub, e.g. inside the content btw.
Member
Author
There was a problem hiding this comment.
Changing to aria-label="Reactions" duplicates that label on the page making semantic selector unusable and my prompt was for semantic selectors only in that test, so I have to turn on of them non-semantic.
Member
Author
There was a problem hiding this comment.
With dbfec11, the button selector uses .select-reaction class, best we can do without introducing a different translation. Will be fixed later.
Use the existing "repo.reactions" translation for the reaction picker dropdown, removing the now-unused "repo.add_reaction" key. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
wxiaoguang
approved these changes
Apr 3, 2026
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
silverwind
commented
Apr 3, 2026
Signed-off-by: silverwind <me@silverwind.io>
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 4, 2026
* main: Update `setup-uv` to v8.0.0 (go-gitea#37101) Fix various bugs (go-gitea#37096) Clean up AppURL, remove legacy origin-url webcomponent (go-gitea#37090) Add e2e reaction test, improve accessibility, enable parallel testing (go-gitea#37081) Fix various legacy problems (go-gitea#37092)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new e2e test for toggling issue reactions via the reaction picker dropdown.
Add
aria-labelattributes to improve reaction accessibility:aria-label="Add reaction"to the reaction picker dropdownrole="group"witharia-label="Reactions"to the reactions container, giving it a semantic identity for screen readersaria-label(e.g.+1: user1, user2) so screen readers announce which reaction a button representsE2e test improvements:
randomStringto useMath.randominstead ofnode:cryptogeneratePasswordwith a static password, remove unusedclickDropdownItemfullyParallel: trueandworkers: '50%'in Playwright configloginandapiCreateReposetup where possibleuser-settingstest for concurrency safetyThis PR was written with the help of Claude Opus 4.6