Always show owner/repo name in compare page dropdowns (#37172)#37200
Merged
Conversation
Fixes: go-gitea#36677 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
bircni
approved these changes
Apr 13, 2026
silverwind
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #37172 by @xingxing21
Fixes: #36677
The fix is a template-only change in templates/repo/diff/compare.tmpl:16-25.
Before, the display names were built with conditional logic:
All four variables defaulted to just the owner name (Examples)
$HeadCompareName was only upgraded to owner/repo format in two narrow cases:
Same org, different repos
A root repo exists with the same owner as the head repo
All other cases (same-repo PRs, cross-org PRs) got owner-only labels
After, all four variables are unconditionally set to owner/repo format using printf "%s/%s":
These variables drive the labels in the base and head branch selector buttons and their dropdown items. No backend changes were needed —$.BaseName, $ .Repository.Name, $.HeadRepo.OwnerName, and $ .HeadRepo.Name were already available in the template context.