Skip to content

Fail vite build on rolldown warnings via NODE_ENV=test #37270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silverwind merged 12 commits into from
Apr 21, 2026
Merged

Fail vite build on rolldown warnings via NODE_ENV=test #37270

Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1df57c9
Bump Vite build target to es2022
silverwind Apr 18, 2026
7b0ea04
Fail Vite build on rolldown warnings in CI
silverwind Apr 18, 2026
dc9a5aa
Apply suggestion from @silverwind
silverwind Apr 18, 2026
91df95d
Merge branch 'main' into es2022
silverwind Apr 18, 2026
7b4590b
Merge branch 'main' into es2022
silverwind Apr 18, 2026
cfc0853
Use plugin with log counter for CI warning failure
silverwind Apr 19, 2026
2415af0
Merge branch 'main' into es2022
silverwind Apr 19, 2026
fd0c24a
Throw from buildEnd instead of calling process.exit
silverwind Apr 19, 2026
0a2f923
Apply suggestion from @silverwind
silverwind Apr 19, 2026
ad2dd2e
Merge branch 'main' into es2022
bircni Apr 21, 2026
f065993
Gate rolldown warn-as-error on NODE_ENV=test
silverwind Apr 21, 2026
70add36
Revert "Gate rolldown warn-as-error on NODE_ENV=test"
silverwind Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,26 @@ const webComponents = new Set([
'text-expander',
]);

function failOnWarningsPlugin(): Rolldown.Plugin {
let warningCount = 0;
return {
name: 'fail-on-warnings',
onLog(level) {
if (level === 'warn') warningCount++;
},
buildEnd() {
if (!warningCount) return;
console.error(`\nerror: ${warningCount} warnings present`);
Comment thread
silverwind marked this conversation as resolved.
Outdated
process.exit(1);
Comment thread
silverwind marked this conversation as resolved.
Outdated
},
};
}

const commonRolldownOptions: Rolldown.RolldownOptions = {
checks: {
pluginTimings: false,
},
...(env.CI ? {plugins: [failOnWarningsPlugin()]} : {}),
};

function commonViteOpts({build, ...other}: InlineConfig): InlineConfig {
Expand Down