Skip to content

refactor: serve site manifest via /assets/site-manifest.json endpoint#37405

Merged
silverwind merged 16 commits into
mainfrom
copilot/refactor-use-web-endpoint-manifest
Apr 24, 2026
Merged

refactor: serve site manifest via /assets/site-manifest.json endpoint#37405
silverwind merged 16 commits into
mainfrom
copilot/refactor-use-web-endpoint-manifest

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 24, 2026 •
edited by wxiaoguang
Loading

Slightly reduce the page size for every request, and don't need to use href="data:

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 24, 2026
@wxiaoguang
Copy link
Copy Markdown
Contributor

wxiaoguang commented Apr 24, 2026

Slightly reduce the page size for every request, and don't need to use href="data: "data" scheme (CSP-related)

@wxiaoguang wxiaoguang marked this pull request as ready for review April 24, 2026 09:58
@wxiaoguang wxiaoguang changed the title refactor: serve site manifest via /assets/site-manifest.json endpoint refactor: serve site manifest via /assets/site-manifest.json endpoint Apr 24, 2026
Copilot AI requested a review from wxiaoguang April 24, 2026 10:29
@wxiaoguang wxiaoguang marked this pull request as draft April 24, 2026 10:56
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2026
@wxiaoguang wxiaoguang marked this pull request as ready for review April 24, 2026 11:26
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 24, 2026
@wxiaoguang wxiaoguang added this to the 1.27.0 milestone Apr 24, 2026
wxiaoguang and others added 2 commits April 24, 2026 19:31
@wxiaoguang
fix comment
57b77fa
@silverwind @claude
address review: spec content-type, private cache, log encode error
c16775b 
The new manifest endpoint derives start_url and icon URLs from per-request
host headers, so a shared/public cache could mix variants across hosts;
switch to a private cache. Use the spec content type
application/manifest+json, and log encode errors instead of dropping them.

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Apr 24, 2026

Some cleanups done in c16775b.

wxiaoguang
wxiaoguang reviewed Apr 24, 2026
View reviewed changes
Comment thread routers/web/misc/misc.go Outdated
@wxiaoguang
Apply suggestion from @wxiaoguang
a3e7c1f 
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2026
@silverwind silverwind enabled auto-merge (squash) April 24, 2026 12:21
@wxiaoguang
Copy link
Copy Markdown
Contributor

wxiaoguang commented Apr 24, 2026

Can you carefully check the AI slop by yourself?

image

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 24, 2026
wxiaoguang
wxiaoguang reviewed Apr 24, 2026
View reviewed changes
Comment thread routers/web/misc/misc.go Outdated
@wxiaoguang
Apply suggestion from @wxiaoguang
ee26d86 
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
wxiaoguang
wxiaoguang reviewed Apr 24, 2026
View reviewed changes
Comment thread tests/integration/view_test.go Outdated
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Apr 24, 2026 •
edited
Loading

Right, public cache should be fine for static content.

@wxiaoguang
align
718bc60 
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
@silverwind silverwind merged commit c5c9713 into main Apr 24, 2026
30 checks passed
@silverwind silverwind deleted the copilot/refactor-use-web-endpoint-manifest branch April 24, 2026 13:01
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 24, 2026
silverwind added a commit to mohammad-rj/gitea that referenced this pull request Apr 24, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into pr-36965-ci
696e792 
* origin/main:
  Stabilize e2e logout propagation test (go-gitea#37403)
  refactor: serve site manifest via `/assets/site-manifest.json` endpoint (go-gitea#37405)
  feat(security): set X-Content-Type-Options: nosniff by default (go-gitea#37354)

# Conflicts:
#	tests/e2e/events.test.ts
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 25, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into reply
aec2f56 
* origin/main: (51 commits)
  Fix color regressions, add `priority` color (go-gitea#37417)
  [skip ci] Updated translations via Crowdin
  Stabilize e2e logout propagation test (go-gitea#37403)
  refactor: serve site manifest via `/assets/site-manifest.json` endpoint (go-gitea#37405)
  feat(security): set X-Content-Type-Options: nosniff by default (go-gitea#37354)
  Refactor pull request view (1) (go-gitea#37380)
  Improve AGENTS.md (go-gitea#37382)
  Remove dead CSS (go-gitea#37376)
  Add pr-review e2e test and speed up e2e tests (go-gitea#37345)
  Drop Fomantic tab, checkbox and form patches (go-gitea#37377)
  fix: dump with default zip type produces uncompressed zip (go-gitea#37401)
  Allow fast-forward-only merge when signed commits are required (go-gitea#37335)
  Introduce `ActionRunAttempt` to represent each execution of a run (go-gitea#37119)
  Move review request functions to a standalone file (go-gitea#37358)
  Fix repo init README EOL (go-gitea#37388)
  Fix org team assignee/reviewer lookups for team member permissions (go-gitea#37365)
  Remove external service dependencies in migration tests (go-gitea#36866)
  Extend issue context popup beyond markdown content (go-gitea#36908)
  fix: commit status reporting (go-gitea#37372)
  Support for Custom URI Schemes in OAuth2 Redirect URIs (go-gitea#37356)
  ...
silverwind added a commit to McMichalK/gitea that referenced this pull request Apr 26, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into filter-by-file-extension
ede430b 
* origin/main: (176 commits)
  Refactor pull request view (3) (go-gitea#37439)
  Update 1.26.1 changelog in main (go-gitea#37442)
  Make GetPossibleUserByID can handle deleted user (go-gitea#37430)
  Fix fetch action redirect (go-gitea#37437)
  Refactor integration test DecodeJSON calls to use generic return value (go-gitea#37432)
  Integrate renovate bot for all dependency updates (go-gitea#37050)
  Refactor pull request view (2) (go-gitea#37428)
  Use MarkLongPolling instead of hard-coded route path (go-gitea#37427)
  Optimize CI caches (go-gitea#37387)
  Update AGENTS.md (go-gitea#37420)
  Update Nix flake (go-gitea#37425)
  [skip ci] Updated translations via Crowdin
  remove excessive quote from terraform instructions (go-gitea#37424)
  Improve testing init, clean up webhook tests (go-gitea#37412)
  Fix color regressions, add `priority` color (go-gitea#37417)
  [skip ci] Updated translations via Crowdin
  Stabilize e2e logout propagation test (go-gitea#37403)
  refactor: serve site manifest via `/assets/site-manifest.json` endpoint (go-gitea#37405)
  feat(security): set X-Content-Type-Options: nosniff by default (go-gitea#37354)
  Refactor pull request view (1) (go-gitea#37380)
  ...

# Conflicts:
#	templates/repo/diff/box.tmpl
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 27, 2026
@zjjhot
Merge branch 'main' into mainzjj
29ce2df 
* main: (33 commits)
  refactor: use named `Permission` field in `Repository` struct instead of anonymous embedding (go-gitea#37441)
  Refactor pull request view (3) (go-gitea#37439)
  Update 1.26.1 changelog in main (go-gitea#37442)
  Make GetPossibleUserByID can handle deleted user (go-gitea#37430)
  Fix fetch action redirect (go-gitea#37437)
  Refactor integration test DecodeJSON calls to use generic return value (go-gitea#37432)
  Integrate renovate bot for all dependency updates (go-gitea#37050)
  Refactor pull request view (2) (go-gitea#37428)
  Use MarkLongPolling instead of hard-coded route path (go-gitea#37427)
  Optimize CI caches (go-gitea#37387)
  Update AGENTS.md (go-gitea#37420)
  Update Nix flake (go-gitea#37425)
  [skip ci] Updated translations via Crowdin
  remove excessive quote from terraform instructions (go-gitea#37424)
  Improve testing init, clean up webhook tests (go-gitea#37412)
  Fix color regressions, add `priority` color (go-gitea#37417)
  [skip ci] Updated translations via Crowdin
  Stabilize e2e logout propagation test (go-gitea#37403)
  refactor: serve site manifest via `/assets/site-manifest.json` endpoint (go-gitea#37405)
  feat(security): set X-Content-Type-Options: nosniff by default (go-gitea#37354)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind silverwind approved these changes

Assignees

@wxiaoguang wxiaoguang

Copilot code review Copilot

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.27.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang @silverwind @GiteaBot