fix: Fix nolyfill for renovate#37537
Merged
Merged
Conversation
Add a `nolyfill` Makefile target that applies `pnpm exec nolyfill install` followed by `pnpm install` to relock, and wire it into renovate's npm postUpgradeTasks before `make svg`. Without this, renovate-generated npm upgrades could leave pnpm overrides out of sync until the next manual `make update-js`. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
GiteaBot
added
the
lgtm/need 2
silverwind
added
the
skip-changelog
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
…ased Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
silverwind
changed the title
nolyfill as renovate post-upgrade stepnolyfill for renovate, tighten urfave/cli pin
Contributor
There was a problem hiding this comment.
Pull request overview
Updates dependency automation to keep frontend polyfill overrides in sync after npm upgrades, and constrains a problematic Go dependency version range to avoid known CLI regressions.
Changes:
- Tighten Renovate’s
github.com/urfave/cli/v3allowed version range to<=3.4.1. - Run
nolyfillas part of Renovate’s npmpostUpgradeTasksalongsidemake svg, and expand file filters to includepackage.json+pnpm-lock.yaml. - Add a dedicated
nolyfillMake target and invoke it fromupdate-js.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| renovate.json5 | Adjusts Renovate rules to pin urfave/cli and run make svg nolyfill for npm updates while allowing lock/package changes to be committed. |
| Makefile | Introduces a nolyfill target and integrates it into update-js to keep pnpm.overrides/lockfile consistent after JS dependency updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
silverwind
commented
May 4, 2026
Signed-off-by: silverwind <me@silverwind.io>
silverwind
changed the title
nolyfill for renovate, tighten urfave/cli pinnolyfill for renovate, tighten urfave/cli pin
bircni
approved these changes
May 4, 2026
GiteaBot
added
lgtm/need 1
lunny
approved these changes
May 4, 2026
GiteaBot
added
lgtm/done
silverwind
changed the title
nolyfill for renovate, tighten urfave/cli pinnolyfill for renovate
silverwind
added
the
reviewed/wait-merge
techknowlogick
approved these changes
May 4, 2026
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
to McMichalK/gitea
that referenced
this pull request
May 5, 2026
* origin/main: (49 commits) ci: lint PR titles with commitlint (go-gitea#37498) Make ServeSetHeaders default to download attachment if filename exists (go-gitea#37552) fix(actions): validate workflow param to prevent 500 error (go-gitea#37546) Fix various problems (go-gitea#37547) docs: fix 4 typos in CHANGELOG.md (go-gitea#37549) [skip ci] Updated translations via Crowdin chore(deps): update action dependencies (go-gitea#37540) fix: Fix `nolyfill` for renovate (go-gitea#37537) Refactor pull request view (7) (go-gitea#37524) Update go js py dependencies (go-gitea#37525) Don't unblock run-level-concurrency-blocked runs in the resolver (go-gitea#37461) Refactor pull request view (6) (go-gitea#37522) Refactor pull request view (5) (go-gitea#37517) fix: persist mirror repository metadata (go-gitea#37519) fix(packages): use file names for generic web downloads (go-gitea#37514) fix: merge autodetect can't close other PRs but only the last one when multiple PRs are pushed at once (go-gitea#37512) Fix update branch protection order (go-gitea#37508) Refactor "flex-list" to "flex-divided-list" (go-gitea#37505) fix: redirect early CLI console logger to stderr (go-gitea#37507) Fix mCaptcha broken after Vite migration (go-gitea#37492) ... # Conflicts: # templates/repo/diff/box.tmpl
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 6, 2026
* main: (36 commits) refactor(deps): migrate from `nektos/act` fork to `gitea/runner` (go-gitea#37557) ci: lint PR titles with commitlint (go-gitea#37498) Make ServeSetHeaders default to download attachment if filename exists (go-gitea#37552) fix(actions): validate workflow param to prevent 500 error (go-gitea#37546) Fix various problems (go-gitea#37547) docs: fix 4 typos in CHANGELOG.md (go-gitea#37549) [skip ci] Updated translations via Crowdin chore(deps): update action dependencies (go-gitea#37540) fix: Fix `nolyfill` for renovate (go-gitea#37537) Refactor pull request view (7) (go-gitea#37524) Update go js py dependencies (go-gitea#37525) Don't unblock run-level-concurrency-blocked runs in the resolver (go-gitea#37461) Refactor pull request view (6) (go-gitea#37522) Refactor pull request view (5) (go-gitea#37517) fix: persist mirror repository metadata (go-gitea#37519) fix(packages): use file names for generic web downloads (go-gitea#37514) fix: merge autodetect can't close other PRs but only the last one when multiple PRs are pushed at once (go-gitea#37512) Fix update branch protection order (go-gitea#37508) Refactor "flex-list" to "flex-divided-list" (go-gitea#37505) fix: redirect early CLI console logger to stderr (go-gitea#37507) ...
silverwind
added a commit
that referenced
this pull request
May 6, 2026
…_COMMANDS (#37565) 1. Sync `RENOVATE_ALLOWED_POST_UPGRADE_COMMANDS` with the recent `renovate.json5` change (#37537) — the npm group now runs `make svg nolyfill`, but the workflow allowlist still only matched `^make (tidy|svg)$`, so the post-upgrade task was being rejected. 2. Bump the cron from daily at 01:00 UTC to hourly at :23, matching the cadence of Mend's hosted Renovate App. Hourly gives sub-hour responsiveness to dependency-dashboard checkbox interactions and PR-close reactions; the `:23` offset avoids the GHA scheduler congestion at multiples of 15. Co-authored-by: Claude (Opus 4.7) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run
nolyfillas a renovate post-upgrade step alongsidemake svg, so npm dep bumps keeppnpm.overridesin sync.This PR was written with the help of Claude Opus 4.7