chore(deps): update regexp2 to v2#37664
Conversation
Updates `github.com/dlclark/regexp2` from v1.12.0 to v2.0.2. The v2 import path is `github.com/dlclark/regexp2/v2`. API usage in `models/issues/pull.go` is unchanged because `RegexOptions` still satisfies the new `CompileOption` interface. The previously-added renovate pin on v1 (for a linux/386 build break, upstream issue dlclark/regexp2#102) is removed, as v2.0.2 contains the fix. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
|
But v1 is still there, it brings nothing useful except bloating the binary size. |
|
v1 will go once https://github.com/alecthomas/chroma updates to it. This problem of duplicate deps isn't exactly new, happens all the time with npm deps. |
Why not wait to then? v1 is still active and well maintained, Upgrading to v2 brings nothing useful. |
|
Waiting is fine, but I don't think we could codify a principle like "wait until dependency dedupes" into renovate so it's manual extra work. |
|
chroma has upgraded in alecthomas/chroma@1cf1560, we can wait on next chroma release here after which it will dedupe. |
|
I find it silly to wait on dependency dedupe, so I would like to merge this update now. |
Isn't it really silly to bloat the binary size with no benefit? |
|
Size impact here is 665kB or +0.46%. I don't think it's worth waiting for 0.46%. |
I also don't think it's worth to improve less than 0.1ms for most pages: #36863 (comment) |
Updates
github.com/dlclark/regexp2fromv1.12.0tov2.0.2. The v2 module uses the/v2import suffix; the single call site (models/issues/pull.go) is otherwise unchanged becauseRegexOptionsstill satisfies the newCompileOptioninterface.Also removes the renovate constraint pinning
regexp2to v1, which was added because v2 failed to build onlinux/386(upstream issue dlclark/regexp2#102). v2.0.2 contains the fix.This PR was written with the help of Claude Opus 4.7