fix: snap build (main branch)#37685
Merged
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
May 13, 2026
GiteaBot
added
lgtm/need 1
lunny
added
the
topic/build
Member
|
If any copilot findings are worth it, replicate the fixes to the other PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Snapcraft build logic for the gitea snap to make the pull/build steps easier to debug and to improve how the snap version/grade are derived from Git metadata during snapcraft.io builds.
Changes:
- Replaces inline
override-pull/override-buildblocks insnapcraft.yamlwith standalone shell scripts. - Adds
snap/part-gitea-pull.shto handle tag selection and to set snapversion/gradeviacraftctl. - Adds
snap/part-gitea-build.shto build and stage thegiteabinary andoptions/into the snap install dir.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| snap/snapcraft.yaml | Moves pull/build overrides to scripts and updates snap description text. |
| snap/part-gitea-pull.sh | New script for snapcraft pull-step tag selection and version/grade computation. |
| snap/part-gitea-build.sh | New script for snapcraft build-step compilation and staging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com>
techknowlogick
approved these changes
May 13, 2026
GiteaBot
added
lgtm/done
silverwind
added a commit
to bircni/gitea
that referenced
this pull request
May 14, 2026
…thor * origin/main: [skip ci] Updated translations via Crowdin fix: snap build (main branch) (go-gitea#37685) chore: introduce HTMLBuilder (go-gitea#37688) chore: clean up "contrib" dir (go-gitea#37690) feat(api): add sort and order query parameters to job list endpoints (go-gitea#37672) fix: Sort action run jobs by JobID and Name with matrix examples (go-gitea#37046) fix: catch and fix more lint problems (go-gitea#37674) docs(agents): update AGENTS.md (go-gitea#37684) fix(actions): run `TransferLogs` on `UpdateLog{Rows:[], NoMore:true}` (go-gitea#37631)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snap info giteaoutputs version 1.22)Legacy logic is kept as is although some of them don't seem good (e.g.: snap version grep, tag finding, etc)
ATTENTION:
Cherry pick #37645