Skip to content

chore(doctor): remove four obsolete doctor check implementations#37728

Merged
wxiaoguang merged 3 commits into
mainfrom
copilot/remove-doctor-service-files
May 16, 2026
Merged

chore(doctor): remove four obsolete doctor check implementations#37728
wxiaoguang merged 3 commits into
mainfrom
copilot/remove-doctor-service-files

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 16, 2026

This PR removes four doctor checks that are no longer desired in the services/doctor package. The change is a hard removal of their implementations and registrations from build/runtime discovery.

  • Scope

    • Deleted:
      • services/doctor/actions.go
      • services/doctor/checkOldArchives.go
      • services/doctor/heads.go
      • services/doctor/authorizedkeys.go
  • Behavioral impact

    • These checks are no longer registered via init() and therefore are no longer available to gitea doctor (including explicit --run by their former names).
  • Code reference

Removed check names:
- disable-mirror-actions-unit
- check-old-archives
- synchronize-repo-heads
- authorized-keys

Co-Authored-By: GitHub Copilot (GPT-5.4) <copilot@github.com>

Co-authored-by: wxiaoguang <2114189+wxiaoguang@users.noreply.github.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 16, 2026
@wxiaoguang wxiaoguang marked this pull request as ready for review May 16, 2026 06:04
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 16, 2026
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 16, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 16, 2026
@wxiaoguang wxiaoguang enabled auto-merge (squash) May 16, 2026 06:36
@bircni bircni added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 16, 2026
@wxiaoguang wxiaoguang merged commit 4e837fe into main May 16, 2026
25 checks passed
@wxiaoguang wxiaoguang deleted the copilot/remove-doctor-service-files branch May 16, 2026 07:19
@GiteaBot GiteaBot added this to the 1.27.0 milestone May 16, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 16, 2026
silverwind added a commit to silverwind/gitea that referenced this pull request May 18, 2026
* origin/main: (39 commits)
  fix: Add missed token scope checking (go-gitea#37735)
  chore: Use giteabot instead of backporter (go-gitea#37422)
  fix: Allow direct commits for unprotected files with push restrictions (go-gitea#37657)
  chore: Conventional adjustments (go-gitea#37677)
  chore(db): introduce db.Session and db.EngineMigration interfaces (go-gitea#37746)
  fix(migrations): preserve unique constraints in v334 sync (go-gitea#37743)
  feat(web): also display PR counts in repo list (go-gitea#37739)
  feat: execute post run cleanup when workflow is cancelled (go-gitea#37275)
  fix(actions): wrong assumption that run id always >= job id (go-gitea#37737)
  fix(icon): use repo-forked icon to display forks count (go-gitea#37731)
  fix(oauth): strengthen PKCE validation and refresh token replay protection (go-gitea#37706)
  fix(web): enforce token scopes on raw, media, and attachment downloads (go-gitea#37698)
  feat: Add bypass allowlist for branch protection (go-gitea#36514)
  refactor(glob): use strings.Builder for regexp compilation (go-gitea#37730)
  feat(oauth): Support AWS Cognito OAuth2 provider (go-gitea#37607)
  feat: Add default PR branch update style setting (go-gitea#37410)
  refactor: move `workflowpattern` into `modules/actions` (go-gitea#37717)
  ci: add `zizmor` to `lint-actions` (go-gitea#37720)
  chore(doctor): remove four obsolete doctor check implementations (go-gitea#37728)
  chore(renovate): enable dockerfile manager (go-gitea#37719)
  ...

# Conflicts:
#	modules/globallock/locker_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants