feat: add copy button to action step header, improve other copy buttons by silverwind · Pull Request #37744 · go-gitea/gitea

silverwind · 2026-05-17T09:13:43Z

Adds a copy button to each action step header that copies the step's rendered log output to clipboard.
Extract a shared copyToClipboard(target, content) helper in clipboard.ts that adds SVG success/failure feedback.
is-loading height for the new helper is sourced from --loading-size.
Change actions log timestamp format to include seconds.

The indented-markdown code-block fix has moved to #37748.

This PR was written with the help of Claude Opus 4.7

Adds a copy button to each action step header that copies the step's rendered log output to clipboard. For collapsed steps the logs are fetched on demand via the existing actions-view endpoint. Along the way: - Extract a shared `copyToClipboard(target, content)` helper in `clipboard.ts` with a re-entry guard and SVG success/failure feedback (octicon-check / octicon-x). Migrates `copycontent.ts` and the dropzone "Copy link" to use it. - Wrap indented markdown code blocks in the same `<div class="code-block-container">` as the fenced renderer so the existing code-copy button applies to both syntaxes. - Spinner height for the new helper is sourced from `--loading-size`, falling back to the previous `min(4em, 66.6%)` for existing callers. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

bircni · 2026-05-17T12:56:24Z

There was also an issue somewhere which requested that...

silverwind · 2026-05-17T22:36:06Z

Was #26116

silverwind · 2026-05-17T22:39:36Z

Wrap indented markdown code blocks the same fenced renderer so the existing code-copy button applies to both syntaxes (pre-existing bug).

FYI this is a problem I encountered while testing the copy buttons. Markdown code block created via indentation were not showing a copy button, now they do. Could potentially extract to another PR.

Moved to its own PR (go-gitea#37748) since it's an independent bug fix. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

silverwind · 2026-05-18T00:14:18Z

markdown code blocks

Extracted to #37748

Copilot

Pull request overview

This PR adds a “copy step output” control to the Actions job step header and consolidates various copy-to-clipboard behaviors behind a shared copyToClipboard() helper that provides inline SVG success/failure feedback and a consistent loading spinner size.

Changes:

Add a copy button to each Actions job step header that copies either rendered logs (expanded) or fetched logs (collapsed).
Refactor existing copy interactions (file content copy, dropzone attachment markdown link copy, global data-clipboard-* handler) to use a shared copyToClipboard() helper with icon feedback.
Adjust loading spinner CSS to support btn-octicon and allow the spinner size to be driven by --loading-size.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
web_src/js/features/repo-actions.ts	Passes the new `copyStepOutput` locale string into the Actions view Vue app.
web_src/js/features/dropzone.ts	Replaces ad-hoc clipboard+tooltip copy with the new `copyToClipboard()` helper.
web_src/js/features/copycontent.ts	Refactors file content copying (including image conversion) to use `copyToClipboard()` with loading handling.
web_src/js/features/clipboard.ts	Introduces `copyToClipboard()` with loading + SVG feedback, and wires it into the global `data-clipboard-*` click handler.
web_src/js/components/ActionRunJobView.vue	Adds the per-step “copy output” button and implements on-demand log fetching for collapsed steps.
web_src/css/modules/animations.css	Ensures `.btn-octicon.is-loading` hides children; makes loading spinner height configurable via `--loading-size`.
templates/repo/actions/view_component.tmpl	Provides `data-locale-copy-step-output` to the Actions view container.
templates/base/head_script.tmpl	Removes global `i18n.copy_success` / `i18n.copy_error` entries.
options/locale/locale_en-US.json	Adds the `copy_step_output` translation string.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

The render path skips both `hidden` and `endgroup` commands (only `group` emits a summary line). The fetch path was skipping only `hidden`, so copying from a collapsed step produced extra blank lines. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

lunny · 2026-05-18T06:39:42Z

Should it copy the timestamp if it displayed?

bircni · 2026-05-18T06:43:36Z

Should it copied the timestamp if it displayed?

No I dont see a use case for that

silverwind · 2026-05-18T06:53:11Z

Should it copy the timestamp if it displayed?

It might be useful for timing-related issues, I'm undecided.

silverwind · 2026-05-18T07:19:29Z

If it's for machine parsing, then yes, raw with timestamp might be better.

wxiaoguang · 2026-05-20T14:09:59Z

Do the new change look good to you? If any doesn't look good, feel free to revert or reset.

silverwind · 2026-05-20T14:19:55Z

Not sure I like this copyTextToClipboard. It's precise which could be beneficial but I don't see why we couldn't just expose ClippieContent on all functions (accept blob + array formats).

wxiaoguang · 2026-05-20T14:40:36Z

Not sure I like this copyTextToClipboard. It's precise which could be beneficial but I don't see why we couldn't just expose ClippieContent on all functions (accept blob + array formats).

Renamed it to copyContentToClipboard

wxiaoguang · 2026-05-20T16:55:21Z

#37744 (comment)

noting this TODO I spotted for me later.

Is this still WIP?

silverwind · 2026-05-20T22:34:04Z

Yes will fix and re-review those functions.

Use the browser's resolved hourCycle (collapsed to h12/h23) instead of the hour12 boolean, so the "Show timestamps" output matches what <relative-time> renders. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

The bare primitive takes the unqualified copyToClipboard; the DOM/feedback variant becomes copyToClipboardWithFeedback, so callers see the difference. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

silverwind · 2026-05-21T00:43:36Z

Functions renamed:

copyToClipboard just copies, no feedback
copyToClipboardWithFeedback copies with feedback and target is required

I think that's the cleanest option by far.

silverwind · 2026-05-21T01:11:24Z

@wxiaoguang looking good?

GiteaBot · 2026-05-21T07:12:27Z

@silverwind please fix the merge conflicts. 🍵

* origin/main: style: misc UI fixes (go-gitea#37691) ci: shard tests and reduce redundant work (go-gitea#37618) chore: simplify issue and pull request templates (go-gitea#37799) # Conflicts: # web_src/js/components/ActionRunJobView.vue

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 17, 2026

silverwind changed the title ~~feat(actions): add copy button to action step header~~ feat(actions): add copy button to action step header, refactor other copy buttons May 17, 2026

silverwind changed the title ~~feat(actions): add copy button to action step header, refactor other copy buttons~~ feat: add copy button to action step header, refactor other copy buttons May 17, 2026

silverwind mentioned this pull request May 17, 2026

Quick copy for action log? #26116

Closed

lunny added the type/enhancement An improvement of existing functionality label May 17, 2026

revert markdown indented code-block wrapper

2bdfde1

Moved to its own PR (go-gitea#37748) since it's an independent bug fix. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

silverwind requested a review from Copilot May 18, 2026 00:15

Copilot started reviewing on behalf of silverwind May 18, 2026 00:19 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread web_src/js/features/clipboard.ts Outdated

Comment thread web_src/js/components/ActionRunJobView.vue Outdated

silverwind changed the title ~~feat: add copy button to action step header, refactor other copy buttons~~ feat: add copy button to action step header, improve other copy buttons May 18, 2026

bircni approved these changes May 18, 2026

View reviewed changes

lunny approved these changes May 18, 2026

View reviewed changes

lunny added this to the 1.27.0 milestone May 18, 2026

wxiaoguang reviewed May 18, 2026

View reviewed changes

Comment thread web_src/js/components/ActionRunJobView.vue Outdated

This comment was marked as resolved.

Sign in to view

wxiaoguang marked this pull request as draft May 18, 2026 07:19

Merge branch 'main' into copy-step-output

f1276ae

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 18, 2026

Merge branch 'main' into copy-step-output

e1d5634

wxiaoguang added 3 commits May 20, 2026 21:56

add more comment for "cursor" type

66eaedc

remove useless null check

b150b3f

remove unnecessary data-clipboard-text-type="url"

6404d38

silverwind commented May 20, 2026

View reviewed changes

Comment thread web_src/js/utils/time.ts Outdated

wxiaoguang added 2 commits May 20, 2026 22:27

copyContentToClipboard

90de798

avoid duplicate querySelector('.octicon-copy')

7888702

wxiaoguang marked this pull request as ready for review May 20, 2026 16:40

Merge branch 'main' into copy-step-output

0324cdc

silverwind marked this pull request as draft May 20, 2026 22:33

silverwind and others added 2 commits May 21, 2026 02:30

formatDatetime: resolve hourCycle like relative-time

a9211be

Use the browser's resolved hourCycle (collapsed to h12/h23) instead of the hour12 boolean, so the "Show timestamps" output matches what <relative-time> renders. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

rename copy functions so feedback is explicit in the name

4e4306b

The bare primitive takes the unqualified copyToClipboard; the DOM/feedback variant becomes copyToClipboardWithFeedback, so callers see the difference. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

silverwind marked this pull request as ready for review May 21, 2026 00:43

Merge branch 'main' into copy-step-output

e0f6086

wxiaoguang approved these changes May 21, 2026

View reviewed changes

silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 21, 2026

silverwind enabled auto-merge (squash) May 21, 2026 07:12

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 21, 2026

silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 21, 2026

silverwind merged commit b7e95cc into go-gitea:main May 21, 2026
24 checks passed

silverwind deleted the copy-step-output branch May 21, 2026 07:39

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 21, 2026

Uh oh!

Conversation

silverwind commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bircni commented May 17, 2026

Uh oh!

silverwind commented May 17, 2026

Uh oh!

silverwind commented May 17, 2026

Uh oh!

silverwind commented May 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

lunny commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bircni commented May 18, 2026

Uh oh!

silverwind commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

silverwind commented May 18, 2026

Uh oh!

wxiaoguang commented May 20, 2026

Uh oh!

Uh oh!

silverwind commented May 20, 2026

Uh oh!

wxiaoguang commented May 20, 2026

Uh oh!

wxiaoguang commented May 20, 2026

Uh oh!

silverwind commented May 20, 2026

Uh oh!

silverwind commented May 21, 2026

Uh oh!

silverwind commented May 21, 2026

Uh oh!

GiteaBot commented May 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

silverwind commented May 17, 2026 •

edited

Loading

lunny commented May 18, 2026 •

edited

Loading

silverwind commented May 18, 2026 •

edited

Loading