ci: fix cache-related issues#37761
Merged
silverwind merged 5 commits intoMay 18, 2026
Merged
Conversation
The lint-go pass typechecks with TAGS=bindata, which requires bindata.dat to exist for the //go:embed directive in modules/options/options_bindata.go. Without generate-go, the seeder lint job fails with: pattern bindata.dat: no matching files found (typecheck). Mirrors the existing fix in pull-compliance.yml's lint-backend job. Regression introduced by go-gitea#37674 (3738809), which added `--build-tags=linux,bindata` to the golangci-lint invocation and patched pull-compliance.yml but missed the matching cache-seeder.yml job. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
GiteaBot
added
the
lgtm/need 2
silverwind
commented
May 18, 2026
Signed-off-by: silverwind <me@silverwind.io>
bircni
approved these changes
May 18, 2026
The `lint-on-demand` job sets up `actions/setup-node` with `cache: pnpm`, but the only unconditional step (`make lint-spell`) is pure Go. The pnpm-using steps (`make deps-frontend lint-md lint-swagger lint-json`, `lint-templates`) only run when files-changed reports matching paths. When all conditionals skip and the cache restore is a miss, `pnpm install` never runs, the pnpm store path stays empty, and `Post Run actions/setup-node` fails with: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved. This has been latent since 1721c23 (go-gitea#37487) merged the per-target lint jobs into a single conditional one. It surfaces whenever the pnpm-lock cache key gets invalidated (e.g. after go-gitea#37753 bumped pnpm-lock.yaml on 2026-05-18) and the failing PR happens not to trigger any pnpm-using step. Drop the pnpm cache here. When the docs/swagger/json/templates branch fires, `make deps-frontend` still runs `pnpm install --frozen-lockfile` against the registry — a small one-time cost on those PRs in exchange for eliminating the failure mode entirely. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
GiteaBot
added
lgtm/need 1
silverwind
changed the title
lunny
approved these changes
May 18, 2026
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
May 19, 2026
* origin/main: (104 commits) fix(deps): update module github.com/go-git/go-git/v5 to v5.19.1 [security] (go-gitea#37786) fix(pull): handle empty pull request files view to allow reviews (go-gitea#37783) fix(markup): make RenderString never fail (go-gitea#37779) fix(markup): wrap indented code blocks for the code-copy button (go-gitea#37748) fix(permissions): Fix reading permission (go-gitea#37769) fix: add natural sort to sortTreeViewNodes (go-gitea#37772) fix: package creation unique conflict (go-gitea#37774) fix(deps): update npm dependencies (go-gitea#37768) fix(deps): update module gitlab.com/gitlab-org/api/client-go/v2 to v2.26.0 (go-gitea#37771) ci: split giteabot workflow (go-gitea#37770) [skip ci] Updated translations via Crowdin fix: Unify public-only token filtering in API queries and repo access checks (go-gitea#37118) fix(deps): update module google.golang.org/grpc to v1.81.1 (go-gitea#37762) chore: make DefaultTitleSource default to auto to match GitHub (go-gitea#37767) ci: fix cache-related issues (go-gitea#37761) chore: fix tests (go-gitea#37760) refactor(waitgroup): replace Add/Done goroutines with WaitGroup.Go (go-gitea#37764) fix(deps): update go dependencies (go-gitea#37752) chore(deps): update action dependencies (go-gitea#37751) fix(deps): update module github.com/google/go-github/v85 to v86 (go-gitea#37754) ... # Conflicts: # .github/workflows/pull-db-tests.yml # modules/storage/s3_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two recurring CI failures:
cache-seeder.ymllint-backend missing amake generate-gobefore linting withTAGS=bindata, andpull-compliance.ymllint-on-demand failing its post-step pnpm cache save when no pnpm-using conditional step runs.cache: pnpmfrom lint-on-demand and addsmake generate-goto cache-seeder's lint job.This PR was written with the help of Claude Opus 4.7