fix(api): use ParseAPIDeadlineToEndOfDay for CreateIssue deadline - #38677
Open
okxint wants to merge 2 commits into
Open
fix(api): use ParseAPIDeadlineToEndOfDay for CreateIssue deadline#38677okxint wants to merge 2 commits into
okxint wants to merge 2 commits into
Conversation
Safari treats inline <span> baseline differently from Chrome/Firefox, causing ActionStatusIcon SVGs to appear vertically misaligned in the action matrix build status list. Adding `display: inline-flex`, `align-items: center`, and `vertical-align: middle` to the wrapper span normalises alignment across browsers. Fixes: go-gitea#38553 Assisted-by: claude-sonnet-4-6
Assisted-by: Claude:claude-sonnet-4-6
GiteaBot
added
the
lgtm/need 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateIssuestored the deadline directly fromform.Deadline.Unix(), preserving whatever time-of-day the client sent. TheEditIssueandCreatePullRequestendpoints both usecommon.ParseAPIDeadlineToEndOfDay, which normalizes the deadline to 23:59:59 in the server's configured timezone.This inconsistency causes issues created via the API to appear as due "yesterday" in the UI when the client sends a date at midnight UTC and the server is in a positive-offset timezone.
One-line fix to use the existing helper consistently.
Closes #37620