enhance(tls): use go's tls defaults - #38687
Open
silverwind wants to merge 2 commits into
Open
Conversation
The hardcoded cipher suites and curve preferences date from 2021 and no longer match what Go ships. Leaving them unset lets crypto/tls decide, so post-quantum key exchange becomes available and the AES-vs-ChaCha hardware check stops duplicating what crypto/tls already does internally. An unset SSL_MAX_VERSION also resolved to TLS 1.2, which silently capped every default HTTPS install below TLS 1.3 on both the manual certificate and ACME paths. All four SSL_* options are kept and now mean "use Go's default" when unset, so a narrower cipher or curve policy can still be configured explicitly. The MinVersion floor in graceful duplicated Go's own server default and prevented GODEBUG=tls10server=1 from ever taking effect. Assisted-by: Claude Code:Opus 5
GiteaBot
added
the
lgtm/need 2
github-actions
Bot
added
type/feature
silverwind
changed the title
github-actions
Bot
added
type/enhancement
Member
Author
|
Wonder if we should flag this as breaking for the change from TLS 1.2 to 1.3. |
silverwind
commented
Jul 28, 2026
Signed-off-by: silverwind <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardcoded cipher suites and curve preferences date from 2021 and no longer match what Go ships. All four
SSL_*are now unset by default which means "use Go's default".X25519MLKEM768) works.ECDHE-*-CBC-SHAsuites become negotiable on TLS 1.2.SSL_CURVE_PREFERENCES=X25519,P256now disables post-quantum.