fix(actions): evaluate expressions in job container config before forwarding to runner - #38696
Open
okxint wants to merge 3 commits into
Open
fix(actions): evaluate expressions in job container config before forwarding to runner#38696okxint wants to merge 3 commits into
okxint wants to merge 3 commits into
Conversation
Safari treats inline <span> baseline differently from Chrome/Firefox, causing ActionStatusIcon SVGs to appear vertically misaligned in the action matrix build status list. Adding `display: inline-flex`, `align-items: center`, and `vertical-align: middle` to the wrapper span normalises alignment across browsers. Fixes: go-gitea#38553 Assisted-by: claude-sonnet-4-6
Assisted-by: Claude:claude-sonnet-4-6
… to runner
RawContainer holds the job-level container config including image, env,
and volumes. These fields can contain workflow expressions such as
${{ env.MY_IMAGE }}, but jobparser never called EvaluateYamlNode on
RawContainer before passing the job to the runner. The runner received
unexpanded expression strings rather than the resolved values.
The adjacent RawContinueOnError field already uses this pattern; apply
the same evaluation call for RawContainer.
GiteaBot
added
the
lgtm/need 2
github-actions
Bot
added
topic/gitea-actions
silverwind
reviewed
Jul 29, 2026
| align-items: center; | ||
| vertical-align: middle; | ||
| } | ||
| </style> |
Member
There was a problem hiding this comment.
Unrelated change? This was already fixed in 8731ea4bbb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RawContainerholds the job-level container configuration (image, env, volumes). These fields support workflow expressions like${{ env.MY_IMAGE }}, butjobparsernever calledEvaluateYamlNodeonRawContainerbefore passing the parsed job to the runner. The runner received the raw expression strings rather than resolved values.Root cause
In
modules/actions/jobparser/jobparser.go, the loop that builds each matrix permutation already evaluatesRawContinueOnErrorviaevaluator.EvaluateYamlNode. The equivalent call was missing forRawContainer.Fix
Add the same three-line evaluation block for
RawContainer, immediately afterRawContinueOnError, mirroring the existing pattern.