fix #4043 clean unlinked webhook and hook_task #4166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 21, 2018 20:01
models/migrations/v67.go
Outdated
| @@ -0,0 +1,13 @@ | |||
| // Copyright 2017 The Gitea Authors. All rights reserved. | |||
bkcsoft
added
the
lgtm/need 2
|
CI Fail. |
lafriks
reviewed
Jun 7, 2018
models/migrations/v67.go
Outdated
| ) | ||
|
|
||
| func cleanUnlinkedWebhookAndHookTasks(x *xorm.Engine) error { | ||
| _, err := x.Exec(`DELETE FROM webhook WHERE (SELECT id FROM repository WHERE id = webhook.repo_id) ISNULL;DELETE FROM hook_task WHERE (SELECT id FROM repository WHERE id = hook_task.repo_id) ISNULL;`) |
There was a problem hiding this comment.
I don't think this will work in PostgreSQL.
SQL should be something like:
DELETE FROM webhook WHERE repo_id not in (SELECT id FROM repository);
DELETE FROM hook_task WHERE repo_id not in (SELECT id FROM repository);
|
/go/src/code.gitea.io/gitea/models/migrations/v67.go:1:1: package comment should be of the form "Package migrations ..." |
Codecov Report
@@ Coverage Diff @@
## master #4166 +/- ##
=======================================
Coverage 19.97% 19.97%
=======================================
Files 153 153
Lines 30494 30494
=======================================
Hits 6091 6091
Misses 23489 23489
Partials 914 914Continue to review full report at Codecov.
|
|
@lunny Wait for merge |
|
Didn't an organization webhook have a zero repository_id? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4043 clean unlinked webhook and hook_task