Skip to content

Update en-us and fr-fr versions of the "Upgrade from Gogs" doc #4618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

deoren
Copy link
Contributor

@deoren deoren commented Aug 5, 2018

Changes

  • header section levels (both)
  • remove header decorations (both)
  • Move "Upgrading to most recent ..." section down as it appears to have been inserted between a bullet point and specific items that need adjusting (en-us)
  • Explicitly specify code syntax to provide syntax highlighting for the examples (both)

Existing issues/PRs

I did not spot an open PR for these changes, but when searching the issues list I found at least two that appear relevant:

Follow-up

Let me know if you'd like changes to this PR and I'll try to work them in. For example, I can squash the commits if you'd rather have them together vs separate as I did here (I guessed that you might prefer them separate since they're different doc files).

deoren added 2 commits August 5, 2018 13:50
- Move "Change gogs specific information" FROM/TO steps up
  to just beneath matching section header, adjust indention
  and explicitly specify syntax of code sample to provide
  highlighting

- Adjust header levels to match what appears to be the
  intended level, remove trailing decoration (see below)

- Move "Upgrading to most recent ..." section down, remove
  decoration (section header formatting likely covers this
  well enough already)

refs go-gitea#4286, go-gitea#3558
- Adjust indention and explicitly specify syntax of code
  sample to provide highlighting

- Adjust header levels to match what appears to be the
  intended level, remove trailing decoration since
  section header formatting likely covers this
  well enough already

refs go-gitea#4286, go-gitea#3558
@codecov-io
Copy link

Codecov Report

Merging #4618 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4618   +/-   ##
=======================================
  Coverage   20.31%   20.31%           
=======================================
  Files         156      156           
  Lines       31245    31245           
=======================================
  Hits         6347     6347           
  Misses      23940    23940           
  Partials      958      958

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c354a5...5c676f6. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 5, 2018
@techknowlogick techknowlogick added type/docs This PR mainly updates/creates documentation modifies/translation labels Aug 6, 2018
@techknowlogick techknowlogick added this to the 1.6.0 milestone Aug 6, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 23, 2018
@lunny
Copy link
Member

lunny commented Aug 24, 2018

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 24, 2018
@techknowlogick
Copy link
Member

make LG-TM work

@techknowlogick techknowlogick merged commit b63e2e0 into go-gitea:master Aug 25, 2018
@deoren deoren deleted the gogs-upgrade-section-order-tweak branch September 16, 2018 18:06
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants